fix(upgrade): return no RC versions if fetching fails #25013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #25012
This commit fixes errors on CI like this:
These errors are caused by the fact that the test server doesn't have an endpoint to return
RC releases. Which in turn causes an error to be raised which later just short-circuits logic
for checking the version and storing it in file. Since fetching from a remote host is always
fallible I elected to just return an empty vec of "rc" versions instead of erroring. This might
lead to a slight mismatch in some situation when the request actually failed and user is
prompted that there's a new canary version, but that is better than not displaying
prompt at all. This issue will be fixed more robustly once we move to using SUI for
specifying version of the binary.