Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(urlpattern): correct typings for added APIs #24881

Merged
merged 5 commits into from
Aug 5, 2024
Merged

fix(urlpattern): correct typings for added APIs #24881

merged 5 commits into from
Aug 5, 2024

Conversation

crowlKats
Copy link
Member

No description provided.

@crowlKats crowlKats changed the title fix(urlpattern): correct typings for added APIs fix(urlpattern): correct typings for added APIs Aug 5, 2024
marvinhagemeister
marvinhagemeister approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green (it's complaining about missing @category in the comments somewhere)

@crowlKats crowlKats merged commit e97764e into denoland:main Aug 5, 2024
17 checks passed
@crowlKats crowlKats deleted the urlpattern-update-typings branch August 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @marvinhagemeister @lucacasonato