BREAKING(webgpu/unstable): Replace async .requestAdapterInfo() with sync .info #24783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with synchronous .info Closes denoland#24779 Ref gpuweb/gpuweb#4662
littledivy
changed the title
petamoriken
reviewed
Jul 29, 2024
| @@ -525,7 +525,7 @@ class GPUAdapter { | |||
| adapterInfo[_architecture] = architecture; | |||
| adapterInfo[_device] = device; | |||
| adapterInfo[_description] = description; | |||
| return PromiseResolve(adapterInfo); | |||
| return adapterInfo; | |||
There was a problem hiding this comment.
Because of the [SameObject] attribute, the info object must be cached as well as features and limits.
There was a problem hiding this comment.
@petamoriken can you open an issue for features and limits?
There was a problem hiding this comment.
Sorry for my bad English, I meant to say that features and limits are already cached and info should be too 😅
There was a problem hiding this comment.
ah my bad, i thought they werent!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24779
Ref gpuweb/gpuweb#4662