Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(urlpattern): add ignoreCase option & hasRegExpGroups property, and fix spec discrepancies #24741

Merged
merged 17 commits into from
Aug 5, 2024
Merged

feat(urlpattern): add ignoreCase option & hasRegExpGroups property, and fix spec discrepancies #24741

merged 17 commits into from
Aug 5, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jul 26, 2024 •
edited
Loading

Fixes #20906
Fixes #24266
Closes #21073

lucacasonato
lucacasonato reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore case option also needs to be handled during regexp construction (line 182)

@crowlKats crowlKats marked this pull request as ready for review July 31, 2024 15:53
lucacasonato
lucacasonato reviewed Aug 1, 2024
View reviewed changes
ext/url/01_urlpattern.js Outdated Show resolved Hide resolved
ext/url/01_urlpattern.js Outdated Show resolved Hide resolved
crowlKats and others added 5 commits August 1, 2024 06:43
@crowlKats @lucacasonato
Apply suggestions from code review
9e0782b 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>
@crowlKats
fix
661d515
@crowlKats
fix
ea8d314
@crowlKats
fix
fb9eb0c
@crowlKats
fmt
1284858
@crowlKats crowlKats changed the title feat: update urlpattern crate feat(urlpattern): add ignoreCase option and fix spec discrepancies Aug 5, 2024
lucacasonato
lucacasonato approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats changed the title feat(urlpattern): add ignoreCase option and fix spec discrepancies feat(urlpattern): add ignoreCase option & hasRegExpGroups property, and fix spec discrepancies Aug 5, 2024
@crowlKats crowlKats merged commit 27ea23e into denoland:main Aug 5, 2024
17 checks passed
@crowlKats crowlKats deleted the update-urlpattern branch August 5, 2024 08:49
@crowlKats crowlKats mentioned this pull request Aug 22, 2024
Merged
crowlKats added a commit that referenced this pull request Aug 22, 2024
@crowlKats
fix(urlpattern): fallback to empty string for undefined group values (#…
9bc7de9 
…25151)

This change was introduced in #24741, but due to the change in
behaviour, we will revert it and re-introduce it in 2.0
crowlKats added a commit to crowlKats/deno that referenced this pull request Aug 22, 2024
@crowlKats
fix(urlpattern): fallback to empty string for undefined group values (d…
9c23c52 
…enoland#25151)

This change was introduced in denoland#24741, but due to the change in
behaviour, we will revert it and re-introduce it in 2.0

(cherry picked from commit 9bc7de9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crowlKats @lucacasonato