fix: support npm:bindings and npm:callsites packages
#24727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes some code from runtime/fmt_errors.rs which is no longer required, due to changes in deno_core. Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
bartlomieju
changed the title
nathanwhit
approved these changes
Jul 25, 2024
bartlomieju
changed the title
npm:bindings and npm:callsites packages
marvinhagemeister
approved these changes
Jul 26, 2024
|
Tried this PR out with the reproductions posted in various issues and it solves the |
|
We should add an integration test for this one. |
dsherret
pushed a commit
that referenced
this pull request
Jul 26, 2024
Adds support for `npm:bindings` and `npm:callsites` packages because of changes in denoland/deno_core#838. This `deno_core` bump causes us to stop prepending `file://` scheme for locations in stack traces that are for local files. Fixes #24462 , fixes #22671 , fixes #15717 , fixes #19130 , fixes WiseLibs/better-sqlite3#1205 , fixes WiseLibs/better-sqlite3#1034 , fixes #20936 --------- Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
|
[edit] moved comment to #15717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
npm:bindingsandnpm:callsitespackages because of changes indenoland/deno_core#838.
This
deno_corebump causes us to stop prependingfile://scheme for locationsin stack traces that are for local files.
Fixes #24462 , fixes #22671 , fixes #15717 , fixes #19130 , fixes WiseLibs/better-sqlite3#1205 , fixes WiseLibs/better-sqlite3#1034 , fixes #20936