Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): hang when caching failed #24651

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 19, 2024

Closes #24600

.await
.client
.show_message(MessageType::WARNING, err);
inner.client.show_message(MessageType::WARNING, err);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug is here

cli/lsp/language_server.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 5f6d84a into denoland:main Jul 20, 2024
17 checks passed
@dsherret dsherret deleted the fix_language_server_hang_cache_failure branch July 20, 2024 01:22
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsxImportSource freezes lsp when deno.json in nested directory is not listed as member of workspace
2 participants