Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use start directory deno.json as "root deno.json config" in npm workspace #24538

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 11, 2024

Tests are in denoland/deno_config#81

Closes #24531

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix

@dsherret dsherret enabled auto-merge (squash) July 11, 2024 20:34
@dsherret dsherret merged commit 77f771b into denoland:main Jul 11, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Jul 11, 2024
@dsherret dsherret deleted the fix_workspace_npm_deno_config_sub_dir branch July 11, 2024 21:51
@dsherret
Copy link
Member Author

Superceeded by #24559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable property in deno.json not working with npm workspaces in v1.45.0
2 participants