Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Fix --allow-scripts with no deno.json #24533

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Jul 11, 2024

We would resolve the wrong package.json, resulting in an inability to run CJS (or other node-mode) scripts

cli/args/mod.rs Outdated Show resolved Hide resolved
@nathanwhit nathanwhit marked this pull request as draft July 11, 2024 18:53
@nathanwhit nathanwhit marked this pull request as ready for review July 11, 2024 23:13
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanwhit nathanwhit merged commit 04f9db5 into denoland:main Jul 15, 2024
17 of 20 checks passed
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
We would resolve the wrong package.json, resulting in an inability to
run CJS (or other node-mode) scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants