-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): update permission prompt message for compiled binaries #24081
fix(cli): update permission prompt message for compiled binaries #24081
Conversation
When running a compiled Deno program that requires permissions, the prompt message previously instructed users to rerun with `--allow-*` flags, which is incorrect for binaries. Changes: - Updated the permission prompt message to instruct users to specify required permissions during the compilation step using `deno compile --allow-*`. - Adjusted `PermissionDenied` error messages to reflect the correct instructions for binaries. This fix ensures that users are correctly informed about how to handle permissions for compiled Deno binaries. Resolves denoland#23250
…-compile-time-permission-specification
Did you write this PR yourself, or is it AI generated? The addition of |
I wrote it, Do you have a better way? |
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-to-indicate-compile-time-permission-specification' into Update-permission-prompt-message-to-indicate-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
Hello @bartlomieju |
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…ermission-prompt-message-to-indicate-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
@bartlomieju Can we merge it? |
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
…-compile-time-permission-specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When running a compiled Deno program that requires permissions, the prompt message previously instructed users to rerun with
--allow-*
flags, which is incorrect for binaries.Changes:
deno compile --allow-*
.PermissionDenied
error messages to reflect the correct instructions for binaries.This fix ensures that users are correctly informed about how to handle permissions for compiled Deno binaries.
Resolves #23250