fix: implement child_process IPC #21490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
commented
Dec 7, 2023
littledivy
commented
Dec 7, 2023
bartlomieju
approved these changes
Dec 13, 2023
| @@ -69,7 +69,6 @@ import { buildAllowedFlags } from "ext:deno_node/internal/process/per_thread.mjs | |||
|
|
|||
| const notImplementedEvents = [ | |||
| "disconnect", | |||
There was a problem hiding this comment.
We should implement this event as well, but let's do that in a follow up PR.
| @@ -203,6 +205,12 @@ class ChildProcess { | |||
| #waitPromise; | |||
| #waitComplete = false; | |||
|
|
|||
| #pipeFd; | |||
| // internal, used by ext/node | |||
| get _pipeFd() { | |||
There was a problem hiding this comment.
This is not great. Can you think of a way how we could not expose it to user code? Let's address that in a follow up.
| @@ -265,7 +265,91 @@ fn create_command( | |||
| value => value.as_stdio(), | |||
| }); | |||
|
|
|||
| Ok(command) | |||
| #[cfg(unix)] | |||
| // TODO(bartlomieju): | |||
There was a problem hiding this comment.
Please address that comment :)
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Node child_process IPC functionality in Deno on Unix systems.
For
fd > 2a duplex unix pipe is set up between the parent and child processes. Currently implements data passing via the channel in the JSON serialization format.