fix(ext/node): fix Buffer.copy when sourceStart > source.length#21345
Merged
kt3k merged 3 commits intodenoland:mainfrom Nov 28, 2023
Merged
fix(ext/node): fix Buffer.copy when sourceStart > source.length#21345kt3k merged 3 commits intodenoland:mainfrom
kt3k merged 3 commits intodenoland:mainfrom
Conversation
Member
|
Looks like the test is actually failing. |
Member
Author
|
Updated the test case. The diff comes from this nodejs/node@2545019#diff-a265cfa759473351948564aded4d796e5ae4d558ad4b51831300c319dadf80f4L127-R127 |
bartlomieju
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables a test case ignored in #21328. The test case revealed the bug of Buffer#copy implementation, which has been fixed in nodejs/node#47758 in Node.js repo.
closes #21335