Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compile): store the npm snapshot in the eszip #19343

Merged
merged 12 commits into from
Jun 8, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 1, 2023

Waiting on denoland/eszip#132

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret marked this pull request as ready for review June 6, 2023 19:39
@dsherret
Copy link
Member Author

dsherret commented Jun 6, 2023

Huh, worked locally for me on Windows, but seems to not work on Linux. I will look into it soon. Hopefully something small.

@dsherret dsherret merged commit 55f0150 into denoland:main Jun 8, 2023
@dsherret dsherret deleted the refactor_store_npm_snapshot_in_eszip branch June 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants