Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use deno_native_certs crate #18072

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Mar 8, 2023

Fixes #18071
Fixes #20996

Replace rustls_native_certs which links to Security framework. https://github.com/denoland/deno_native_certs uses dlopen to lazy load when needed.

@littledivy littledivy marked this pull request as ready for review March 8, 2023 17:52
@littledivy littledivy changed the title [wip] perf: use deno_native_certs crate perf: use deno_native_certs crate Mar 8, 2023
@bartlomieju
Copy link
Member

Is there any noticable startup performance difference with this PR?

@littledivy
Copy link
Member Author

No difference, this itself isn't enough to get rid of Security framework. See #18071

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of landing this PR unless we can show end-to-end improvement in startup time.

@littledivy littledivy requested a review from bartlomieju October 7, 2023 18:13
Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
@littledivy littledivy mentioned this pull request Oct 27, 2023
11 tasks
@littledivy littledivy enabled auto-merge (squash) October 27, 2023 17:17
Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
@littledivy
Copy link
Member Author

target/debug/deno:
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1953.255.0)
	/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1228.0.0)
	/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1241.60.3)
	/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)

SecurityFramework gone :-)

@littledivy littledivy merged commit ba6bd44 into denoland:main Oct 31, 2023
12 checks passed
@bartlomieju bartlomieju deleted the deno_native_certs branch October 31, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero macOS framework dependencies lazily load Security framework on macOS
2 participants