-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(runtime/spawn): collect output using op_read_all
#16596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcosc90 Can you drop the benchmark source somewhere in cli/bench
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think LGTM! Thanks.
@lucacasonato can you take a look? 🙏 |
Done @littledivy |
https://github.com/denoland/deno/actions/runs/3457193770/jobs/5770460515#step:34:3397 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. Looks great overall.
ext/web/06_streams.js
Outdated
@@ -767,16 +768,24 @@ | |||
return stream; | |||
} | |||
|
|||
function readableStreamUnrefable(stream) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function readableStreamUnrefable(stream) { | |
function readableStreamIsUnrefable(stream) { |
ext/web/06_streams.js
Outdated
const _resourceBacking = Symbol("[[resourceBacking]]"); | ||
const _resourceBackingUnrefable = Symbol("[[resourceBackingUnrefable]]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This distinction exists to prevent unrefable streams being used in regular fast streams that are unaware of refability? Please add a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, added the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @marcosc90!
This patch
main