-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/bench): skip strace table border #16310
Conversation
Found the root cause, the table separator is not skipped correctly because the output begins with:
And we're only skipping |
!line.is_empty() | ||
&& !line.contains("detached ...") | ||
&& !line.contains("unfinished ...") | ||
&& !line.contains("????") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is future proofing, since I do not know all possible strace states that are sometimes present at the beginning of the file, but it seems that all of them contains ????
87381 ????( <unfinished ...>
87358 ????( <detached ...>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for digging into this @marcosc90
It crashes due to the table border output from `strace`, ``` % time seconds usecs/call calls errors syscall ------ ----------- ----------- --------- --------- ---------------- # this is skipped correctly 61.27 6.012053 678 8860 637 futex 0.00 0.000000 0 4 geteuid ------ ----------- ----------- --------- --------- ---------------- # this causes the crash 100.00 11.732230 25552 1205 total ``` It's flaky because that line is not always skipped from the output, for some reason that I've yet to find out.
Fixes #16302
It crashes due to the table border output from
strace
,It's flaky because that line is not always skipped from the output, for some reason that I've yet to find out.
deno/test_util/src/lib.rs
Lines 2201 to 2212 in 323ddc8