Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/web): use mimesniff in FileAPI #16233

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+99 −1,755
Open

fix(ext/web): use mimesniff in FileAPI #16233

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d8b9a1e
fix(ext/mimesniff): fix parseMimeType
marcosc90 Oct 10, 2022
c18129f
use parseMimeType in normalizeType
marcosc90 Oct 10, 2022
b50e590
Merge branch 'main' into fix-mimesniff
marcosc90 Oct 29, 2022
e834da4
enable tests
marcosc90 Oct 29, 2022
46ad0d6
Merge branch 'main' into fix-mimesniff
bartlomieju Oct 30, 2022
8e78e17
disable broken blob tests
marcosc90 Oct 31, 2022
5851b14
disable broken tests
marcosc90 Oct 31, 2022
be3f2ef
Merge branch 'main' into fix-mimesniff
crowlKats Jan 13, 2023
f62a991
Merge branch 'main' into fix-mimesniff
aapoalas Jul 7, 2023
2d9866d
Fix lint
aapoalas Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable broken tests
  • Loading branch information
@marcosc90
marcosc90 committed Oct 31, 2022
commit 5851b14f7c9392806bbad62629e4453c2f692044
30 changes: 24 additions & 6 deletions tools/wpt/expectation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,8 +2668,14 @@
"Check that no-cors request constructor is filtering headers provided as init parameter",
"Check that no-cors request constructor is filtering headers provided as part of request parameter"
],
"request-init-contenttype.any.html": true,
"request-init-contenttype.any.worker.html": true,
"request-init-contenttype.any.html": [
"Default Content-Type for Request with Blob body (set type)",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails because it expects a/b; c=d, but we're now setting to a/b;c=d as per the MIME Sniffing spec

"Default Content-Type for Request with FormData body"
],
"request-init-contenttype.any.worker.html": [
"Default Content-Type for Request with Blob body (set type)",
"Default Content-Type for Request with FormData body"
],
"request-structure.any.html": [
"Check destination attribute",
"Check referrer attribute",
Expand Down Expand Up @@ -3075,8 +3081,14 @@
],
"response-consume-stream.any.html": true,
"response-consume-stream.any.worker.html": true,
"response-init-contenttype.any.html": true,
"response-init-contenttype.any.worker.html": true,
"response-init-contenttype.any.html": [
"Default Content-Type for Response with Blob body (set type)",
"Default Content-Type for Response with FormData body"
],
"response-init-contenttype.any.worker.html": [
"Default Content-Type for Response with Blob body (set type)",
"Default Content-Type for Response with FormData body"
],
"response-static-json.any.html": true,
"response-static-json.any.worker.html": true
},
Expand Down Expand Up @@ -3346,8 +3358,14 @@
"Blob-in-worker.worker.html": true
},
"file": {
"File-constructor.any.html": true,
"File-constructor.any.worker.html": true,
"File-constructor.any.html": [
"Using type in File constructor: text/plain;charset=UTF-8",
"Using type in File constructor: nonparsable"
],
"File-constructor.any.worker.html": [
"Using type in File constructor: text/plain;charset=UTF-8",
"Using type in File constructor: nonparsable"
],
"send-file-formdata-controls.any.html": true,
"send-file-formdata-controls.any.worker.html": true,
"send-file-formdata-punctuation.any.html": true,
Expand Down