-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/cache): illegal constructor #16205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should rather be using webidl.createBranded
& also have brand assertions in all the methods
cli/tests/unit/cache_api_test.ts
Outdated
Deno.test(function cacheIllegalConstructor() { | ||
// @ts-ignore illegal constructor | ||
assertThrows(() => new Cache(), TypeError, "Illegal constructor"); | ||
// @ts-ignore illegal constructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// @ts-expect-error maybe better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
fixes #16199
There is no
constructor
ininterface Cache {}
https://w3c.github.io/ServiceWorker/#cache-interface