feat: update checker #15543
feat: update checker #15543
Conversation
|
You don't want this running under the lsp subcommand, as the output would be missed. I assume there are other subcommands it should be supressed. Also, it seems to check every invocation? |
| let client = client_builder.build()?; | ||
|
|
||
| let ver = if version::is_canary() { | ||
| let res = client.get("https://version.deno.dev/canary").send().await?; |
There was a problem hiding this comment.
hardcoded values "buried" in code feels bad... maybe should be extracted out as a const?
There was a problem hiding this comment.
We can just use https://dl.deno.land/release-latest.txt and https://dl.deno.land/canary-latest.txt for this.
| let client = client_builder.build()?; | ||
|
|
||
| let ver = if version::is_canary() { | ||
| let res = client.get("https://version.deno.dev/canary").send().await?; |
There was a problem hiding this comment.
shouldn't we be setting the UA string like with the file fetcher?
|
yes, it shouldnt run under some subcommands, and yes, it shouldnt run on every invocation; PR is not ready yet |
ok, let me know when you want me to complain |
|
To avoid ruining startup time, I think we should do the check in the background and display update info on the next invocation. |
| colors::green_bold(format!( | ||
| "Version '{ver}' of Deno is out, update with `deno upgrade`." | ||
| )) | ||
| ); |
There was a problem hiding this comment.
I was just thinking that we should maybe only output this when stderr is a tty (and this outputs to stderr instead). That way we won’t randomly break anyone piping deno process output.
|
Closing in favor of #15974 |
No description provided.