Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add performance.timeOrigin #14489

Merged
merged 17 commits into from
May 6, 2022
Merged

feat(web): add performance.timeOrigin #14489

merged 17 commits into from
May 6, 2022

Conversation

GJZwiers
Copy link
Contributor

@GJZwiers GJZwiers commented May 4, 2022

Revival of #10843.

Adds the timeOrigin property of the Performance API. Closes #10837.

@GJZwiers GJZwiers marked this pull request as ready for review May 5, 2022 12:01
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want @lucacasonato's review before landing

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How much of this code did you copy from the earlier PR? Should I add a Co-authored-by?

@GJZwiers
Copy link
Contributor Author

GJZwiers commented May 6, 2022

I'm happy to credit @JoviDeCroock for the initial efforts, it's about 50-50 in terms of contributed code I think.

@lucacasonato lucacasonato merged commit dd1d6a0 into denoland:main May 6, 2022
@GJZwiers GJZwiers deleted the time_origin branch May 7, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing performance.timeOrigin
3 participants