Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/tools/test): Show Deno.test() call locations for failures #14484

Merged
merged 2 commits into from
May 4, 2022

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented May 4, 2022

Closes #14481.
Closes #14190

See https://github.com/denoland/deno/blob/ab5652c35f98ae34a7648eddbc96f53e2e4fdaaf/cli/tests/testdata/test/fail.out for an example, the other fixtures have wildcarded lines/columns.

cli/tests/testdata/test/exit_sanitizer.out Show resolved Hide resolved
cli/tools/test.rs Show resolved Hide resolved
cli/tools/test.rs Outdated Show resolved Hide resolved
runtime/js/40_testing.js Outdated Show resolved Hide resolved
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Nayeem

@bartlomieju bartlomieju merged commit ca134d2 into denoland:main May 4, 2022
@nayeemrmn nayeemrmn deleted the failed-test-location branch May 5, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.test() call location in test failures test: Better headers for the three deno test sections
2 participants