Add prebuilt hyperfine and sccache binaries #1370
Conversation
ry
force-pushed
the
hyperfine_prebuilt
branch
from
f9d240d to
0f43e2d
Compare
Use prebuilt sccache in CI
ry
force-pushed
the
hyperfine_prebuilt
branch
from
a4a6b94 to
f9e144a
Compare
| @@ -113,8 +113,12 @@ def generate_gn_args(mode): | |||
| if "DENO_BUILD_ARGS" in os.environ: | |||
| out += os.environ["DENO_BUILD_ARGS"].split() | |||
|
|
|||
| cacher = prebuilt.load_sccache() | |||
| if not os.path.exists(cacher): | |||
There was a problem hiding this comment.
I think this branch is unnecessary -- if load_sccache() succeeds then this path will exist.
There was a problem hiding this comment.
It'd also be nice if we could somehow move sccache detection out of setup.py entirely. I think the goal should be to not rely on a generated args.gn file eventually. (Not in this patch tho).
There was a problem hiding this comment.
Yeah this branch is never taken, but I thought it would be good to leave it in if someone wanted to add some feature like --no-prebuilt-sscache
There was a problem hiding this comment.
I agree we should not rely on generated args.gn (other than is_official_release=true) - we can do that now by hard coding a default path to sscache now that we know it's going to be there.
Use prebuilt sccache in CI
This is the last step necessary so that we can set CARGO_HOME to third_party/rust_crates