-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/net): Add Conn.setNoDelay and Conn.setKeepAlive #13103
Merged
+240
−0
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
14968b1
implement op_set_nodelay for ext/net
yos1p 59f86b3
Add setNoDelay fn in d.ts
yos1p d1f3d8e
Fix op_set_nodelay implementation
yos1p d6c7f41
Change op_set_no_delay to sync
yos1p 42f34dc
Default parameter of setNoDelay to true
yos1p ade7423
Fix setNoDelay and add some test
yos1p edbea11
Prototype test for tcp setnodelay
yos1p 8c57963
rollback test
yos1p 5e04c43
Add set_keepalive & socket2 dependency
yos1p e80a6bd
Use closure to set socket options
yos1p 00f422a
Add ops test for set_nodelay and set_keepalive
yos1p 843890c
fix import in test
yos1p 2b3dbe6
Use main server as tcp test
yos1p 2ed4fdd
Fix addr in use issue in test
yos1p 5f7cf60
fix test
yos1p bc2efe2
Merge branch 'main' into set_nodelay
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that:
readResult
equals3
readResult
is aconst
and assigned a primitiveDo we need this assertion or is it redundant?