-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove denort optimization #10350
Remove denort optimization #10350
Conversation
denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output.
Are you saying that lite will become the default for compile binaries? Or that instead all binaries will include unnecessary code like the formatter, linter, bundler, webgpu etc. I understand wanting to have less build complexity for sure but curious if there any size goals are for compiled binaries compared to the normal deno executable |
@ry Maybe a good tradeoff would be to only enable |
But in general I agree that having faster CI is more beneficial to deno (improving iteration speed) than smaller binaries for |
Would it make sense to provide docs like "How to compile a minimal Deno yourself with less features"? Not sure if custom builds would be approachable to devs interested in smaller executables but without deep knowledge of Deno's workings - maybe it's as simple as commenting out components from the entry point file (likely not 😅) or maybe is Deno simply too tightly wired together to drop any features without panics... |
LGTM. @bartlomieju ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
denort is an optimization to "deno compile" to produce slightly smaller
output. It's a decent idea, but causes a lot of negative side-effects:
denort doubles link time.
steps. denort necessitates an additional manual zip + upload from M1
apple computers.
This is confusing for uses ("why wouldn't you want lite?").
The benefits of this feature do not outweigh the negatives. We must find
a different approach to optimizing "deno compile" output.
Fixes #10056