Bug: Unexpected reserved word panic when building with `cargo build --features hmr`

[marvinhagemeister]

Version: Deno 2.1.6-canary 4e0bf4b

I'm not able to reproduce it in 2.1.6 but in latest canary 4e0bf4b09.

Steps to reproduce

1. Create an .npmrc file with these contents:

@buf:registry=https://buf.build/gen/npm/v1/

2. Create file foo.ts with these contents:

import * as foo from "npm:@buf/wcygan_flock.bufbuild_es";
console.log(foo);

3. Run deno run foo.ts

Output

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: macos aarch64
Version: 2.1.6
Args: ["/Users/marvinh/dev/denoland/deno/target/debug/deno", "run", "foo.ts"]

thread 'main' panicked at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.331.0/runtime/jsruntime.rs:740:9:
Failed to initialize a JsRuntime: Uncaught SyntaxError: Unexpected reserved word
    at ext:deno_telemetry/telemetry.ts:55:1
stack backtrace:
   0: rust_begin_unwind
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:662:5
   1: core::panicking::panic_fmt
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/panicking.rs:74:14
   2: deno_core::runtime::jsruntime::JsRuntime::new
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.331.0/runtime/jsruntime.rs:740:9
   3: deno_runtime::worker::MainWorker::from_options
             at /Users/marvinh/dev/denoland/deno/runtime/worker.rs:496:26
   4: deno_runtime::worker::MainWorker::bootstrap_from_options
             at /Users/marvinh/dev/denoland/deno/runtime/worker.rs:314:7
   5: deno_lib::worker::LibMainWorkerFactory<TSys>::create_custom_worker
             at /Users/marvinh/dev/denoland/deno/cli/lib/worker.rs:510:7
   6: deno::worker::CliMainWorkerFactory::create_custom_worker::{{closure}}
             at /Users/marvinh/dev/denoland/deno/cli/worker.rs:429:22
   7: deno::worker::CliMainWorkerFactory::create_main_worker::{{closure}}
             at /Users/marvinh/dev/denoland/deno/cli/worker.rs:369:8
   8: deno::tools::run::run_script::{{closure}}
             at /Users/marvinh/dev/denoland/deno/cli/tools/run/mod.rs:81:6
   9: deno::run_subcommand::{{closure}}::{{closure}}
             at /Users/marvinh/dev/denoland/deno/cli/main.rs:206:103
  10: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.31/src/future/future/map.rs:55:37
  11: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.31/src/lib.rs:86:13
  12: deno::spawn_subcommand::{{closure}}
             at /Users/marvinh/dev/denoland/deno/cli/main.rs:104:40
  13: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/future/future.rs:123:9
  14: <deno_unsync::tokio::task::MaskFutureAsSend<F> as core::future::future::Future>::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_unsync-0.4.2/src/tokio/task.rs:134:13
  15: tokio::runtime::task::core::Core<T,S>::poll::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/core.rs:328:17
  16: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/loom/std/unsafe_cell.rs:16:9
  17: tokio::runtime::task::core::Core<T,S>::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/core.rs:317:13
  18: tokio::runtime::task::harness::poll_future::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/harness.rs:485:19
  19: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/panic/unwind_safe.rs:272:9
  20: std::panicking::try::do_call
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:554:40
  21: ___rust_try
  22: std::panicking::try
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:518:19
  23: std::panic::catch_unwind
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panic.rs:345:14
  24: tokio::runtime::task::harness::poll_future
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/harness.rs:473:18
  25: tokio::runtime::task::harness::Harness<T,S>::poll_inner
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/harness.rs:208:27
  26: tokio::runtime::task::harness::Harness<T,S>::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/harness.rs:153:15
  27: tokio::runtime::task::raw::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/raw.rs:271:5
  28: tokio::runtime::task::raw::RawTask::poll
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/raw.rs:201:18
  29: tokio::runtime::task::LocalNotified<S>::run
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/task/mod.rs:416:9
  30: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:700:25
  31: tokio::runtime::coop::with_budget
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/coop.rs:107:5
  32: tokio::runtime::coop::budget
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/coop.rs:73:5
  33: tokio::runtime::scheduler::current_thread::Context::run_task::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:343:43
  34: tokio::runtime::scheduler::current_thread::Context::enter
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:404:19
  35: tokio::runtime::scheduler::current_thread::Context::run_task
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:343:23
  36: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:699:35
  37: tokio::runtime::scheduler::current_thread::CoreGuard::enter::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:737:68
  38: tokio::runtime::context::scoped::Scoped<T>::set
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context/scoped.rs:40:9
  39: tokio::runtime::context::set_scheduler::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context.rs:176:26
  40: std::thread::local::LocalKey<T>::try_with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:283:12
  41: std::thread::local::LocalKey<T>::with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:260:9
  42: tokio::runtime::context::set_scheduler
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context.rs:176:9
  43: tokio::runtime::scheduler::current_thread::CoreGuard::enter
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:737:27
  44: tokio::runtime::scheduler::current_thread::CoreGuard::block_on
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:646:19
  45: tokio::runtime::scheduler::current_thread::CurrentThread::block_on::{{closure}}
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:175:28
  46: tokio::runtime::context::runtime::enter_runtime
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context/runtime.rs:65:16
  47: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:167:9
  48: tokio::runtime::runtime::Runtime::block_on
             at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/runtime.rs:348:47
  49: deno_runtime::tokio_util::create_and_run_current_thread_inner
             at /Users/marvinh/dev/denoland/deno/runtime/tokio_util.rs:111:11
  50: deno_runtime::tokio_util::create_and_run_current_thread_with_maybe_metrics
             at /Users/marvinh/dev/denoland/deno/runtime/tokio_util.rs:136:3
  51: deno::main
             at /Users/marvinh/dev/denoland/deno/cli/main.rs:429:16
  52: core::ops::function::FnOnce::call_once
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[bartlomieju]

This looks like an internal panic - are you building locally, or pulling canary via deno upgrade?

[marvinhagemeister]

Did build locally. Haven't checked deno upgrade canary.

[bartlomieju]

This is most likely a regression from #27721

[kyleconroy]

I'm able to reproduce this running the runtime example https://github.com/denoland/deno/blob/main/runtime/examples/extension/main.rs