Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows fs node compat regression: await open(os.devNull) fails on 1.43 #23721

Closed
chrisdickinson opened this issue May 6, 2024 · 0 comments · Fixed by #23741
Closed

windows fs node compat regression: await open(os.devNull) fails on 1.43 #23721

chrisdickinson opened this issue May 6, 2024 · 0 comments · Fixed by #23741
Labels
bug Something isn't working correctly ext/fs

Comments

@chrisdickinson
Copy link

chrisdickinson commented May 6, 2024

Version: Deno v1.43.1

The cross-platform library I maintain1, which tests against the latest Deno, started reporting errors on Windows builds after 1.43 launched.

This appears to fail with NotFound: entity not found: open '\\.\nul' as of Deno v1.43, but passes on Deno v1.42.4. I have not tested Deno v1.43.0.

A reduced case would be:

import { devNull } from 'node:os';
import { open } from 'node:fs/promises';
await open(devNull, 'r');
error: Uncaught (in promise) NotFound: entity not found: open '\\.\nul'
await open(devNull, 'r');
      ^
    at Object.open (ext:deno_fs/30_fs.js:633:21)
    at open (ext:deno_node/_fs/_fs_open.ts:76:10)
    at ext:deno_node/_fs/_fs_open.ts:81:5
    at new Promise (<anonymous>)
    at openPromise (ext:deno_node/_fs/_fs_open.ts:80:10)
    at file:///.../main.ts:3:7

Footnotes

  1. The Extism JS SDK, a Wasm framework. (This is kind of to the side of the bug report, but we miss the WASI bindings!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly ext/fs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants