Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] child_process stdio streams not supported #19159

Closed
marvinhagemeister opened this issue May 16, 2023 · 1 comment · Fixed by #19171
Closed

[node] child_process stdio streams not supported #19159

marvinhagemeister opened this issue May 16, 2023 · 1 comment · Fixed by #19171
Labels
bug Something isn't working correctly node compat

Comments

@marvinhagemeister
Copy link
Contributor

Getting this error with npm-run-all.

ERROR: Not implemented: toDenoStdio pipe=object ([object Object])

Steps to reproduce

  1. Create a file foo.ts and paste this into it
import child_process from 'node:child_process';
import process from 'node:process';

child_process.spawn(process.execPath, ['bar.js'], {
	stdio: [process.stdin, process.stdout, process.stderr]
});
  1. Create a file bar.js in the same directory with the following content:
console.log("hey");
  1. Run deno run -A foo.ts
@marvinhagemeister marvinhagemeister changed the title [npm] child_process stdio not supported [node] child_process stdio not supported May 16, 2023
@marvinhagemeister marvinhagemeister changed the title [node] child_process stdio not supported [node] child_process stdio streams not supported May 17, 2023
@marvinhagemeister
Copy link
Contributor Author

I have a fix for this but I cannot push to GitHub. Maybe they haven't fully resolved the incident from yesterday despite their status page being all green.

@bartlomieju bartlomieju added bug Something isn't working correctly node compat labels May 17, 2023
bartlomieju pushed a commit that referenced this issue May 18, 2023
This is a bit bare bones but gets `npm-run-all` working. For full stdio
compatibility with node more work is needed which is probably better
done in follow up PRs.

Fixes #19159
levex pushed a commit that referenced this issue May 18, 2023
This is a bit bare bones but gets `npm-run-all` working. For full stdio
compatibility with node more work is needed which is probably better
done in follow up PRs.

Fixes #19159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants