Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions after Deno.serve are not thrown #15869

Closed
Tracked by #17146
sigmaSd opened this issue Sep 12, 2022 · 0 comments · Fixed by #18568
Closed
Tracked by #17146

Exceptions after Deno.serve are not thrown #15869

sigmaSd opened this issue Sep 12, 2022 · 0 comments · Fixed by #18568
Labels
bug Something isn't working correctly

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented Sep 12, 2022 

Deno.serve(() => new Response("ok"));

throw "azez" // no exception is thrown

deno 1.25.2+ffffa2f (canary, x86_64-unknown-linux-gnu)
@lucacasonato lucacasonato mentioned this issue Sep 12, 2022
Closed
@littledivy littledivy added bug Something isn't working correctly flash labels Sep 12, 2022
@bartlomieju bartlomieju mentioned this issue Dec 20, 2022
Closed
18 tasks
@bartlomieju bartlomieju mentioned this issue Apr 3, 2023
Merged
levex pushed a commit that referenced this issue Apr 12, 2023
@bartlomieju @levex
refactor: "Deno.serve()" API uses "Deno.serveHttp()" internally (#18568)
fe21f65 
This commit changes implementation of "Deno.serve()" API to use
"Deno.serveHttp()" under the hood. This change will allow us to
remove the "flash" server implementation, bringing stability to the
"Deno.serve()" API.

"cli/tests/unit/flash_test.ts" was renamed to "serve_test.ts".

Closes #15574
Closes #15504
Closes #15646
Closes #15909
Closes #15911
Closes #16828
Closes #18046
Closes #15869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: "Deno.serve()" API uses "Deno.serveHttp()" internally bartlomieju/deno
2 participants
@sigmaSd @littledivy