refactor: remove "ext/flash" (#18578)

With #18568 landed we no longer need "ext/flash". This commit removes "deno_flash" extension completely. This should have some impact on the binary and snapshot size. Closes #17356
denoland · Apr 12, 2023 · aa3f85d · aa3f85d
1 parent fe21f65
commit aa3f85d
Show file tree

Hide file tree

Showing 27 changed files with 1 addition and 3,125 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -18,7 +18,6 @@ members = [
   "ext/console",
   "ext/crypto",
   "ext/fetch",
-  "ext/flash",
   "ext/ffi",
   "ext/fs",
   "ext/http",
@@ -62,7 +61,6 @@ deno_console = { version = "0.97.0", path = "./ext/console" }
 deno_crypto = { version = "0.111.0", path = "./ext/crypto" }
 deno_fetch = { version = "0.121.0", path = "./ext/fetch" }
 deno_ffi = { version = "0.84.0", path = "./ext/ffi" }
-deno_flash = { version = "0.33.0", path = "./ext/flash" }
 deno_fs = { version = "0.7.0", path = "./ext/fs" }
 deno_http = { version = "0.92.0", path = "./ext/http" }
 deno_io = { version = "0.7.0", path = "./ext/io" }
@@ -265,8 +263,6 @@ opt-level = 3
 opt-level = 3
 [profile.release.package.deno_http]
 opt-level = 3
-[profile.release.package.deno_flash]
-opt-level = 3
 [profile.release.package.deno_net]
 opt-level = 3
 [profile.release.package.deno_web]

diff --git a/cli/bench/http/deno_http_flash_ops.js b/cli/bench/http/deno_http_flash_ops.js
diff --git a/cli/bench/http/deno_http_flash_ops_spawn.js b/cli/bench/http/deno_http_flash_ops_spawn.js
diff --git a/cli/bench/http/deno_http_flash_post_bin.js b/cli/bench/http/deno_http_flash_post_bin.js
diff --git a/cli/bench/http/deno_http_flash_post_bin.lua b/cli/bench/http/deno_http_flash_post_bin.lua
diff --git a/cli/bench/http/deno_http_flash_spawn.js b/cli/bench/http/deno_http_flash_spawn.js
diff --git a/cli/bench/http/deno_http_flash.js → cli/bench/http/deno_http_serve.js b/cli/bench/http/deno_http_flash.js → cli/bench/http/deno_http_serve.js
diff --git a/cli/build.rs b/cli/build.rs
@@ -362,7 +362,6 @@ fn create_cli_snapshot(snapshot_path: PathBuf) {
     deno_http::deno_http::init_ops(),
     deno_io::deno_io::init_ops(Default::default()),
     deno_fs::deno_fs::init_ops::<PermissionsContainer>(false),
-    deno_flash::deno_flash::init_ops::<PermissionsContainer>(false), // No --unstable
     deno_node::deno_node::init_ops::<deno_runtime::RuntimeNodeEnv>(None),
     cli::init_ops_and_esm(), // NOTE: This needs to be init_ops_and_esm!
   ];

diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs
@@ -4230,13 +4230,6 @@ itest!(config_file_lock_true {
   exit_code: 10,
 });
 
-// TODO(bartlomieju): this test is flaky on CI, reenable it after debugging
-// // Check https://github.com/denoland/deno_std/issues/2882
-// itest!(flash_shutdown {
-//   args: "run --unstable --allow-net run/flash_shutdown/main.ts",
-//   exit_code: 0,
-// });
-
 itest!(permission_args {
   args: "run run/001_hello.js --allow-net",
   output: "run/permission_args.out",

diff --git a/cli/tests/testdata/run/flash_shutdown/main.ts b/cli/tests/testdata/run/flash_shutdown/main.ts