Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: uri parser authSource and dbName bug #265

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Fix: uri parser authSource and dbName bug #265

merged 2 commits into from
Oct 8, 2021

Conversation

erfanium
Copy link
Member

Currently when authSource and dbName comes together, parse ignores dbName that is not expected

src/utils/uri.ts Outdated Show resolved Hide resolved
@erfanium erfanium requested a review from manyuanrong October 4, 2021 11:38
@erfanium
Copy link
Member Author

erfanium commented Oct 4, 2021

I also changed the default db name from admin to test. That's the behavior from official mongodb driver for node

@denodrivers denodrivers deleted a comment from manuelaguirre Oct 4, 2021
Copy link

@nerdkid93 nerdkid93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just encountered this error in the mongo@v0.27.0 release, and when I point my import map to your branch instead of deno.land, the auth issues I was encountering are fixed (although it might be worth updating the README.md Example to demonstrate the new behavior)

@erfanium
Copy link
Member Author

erfanium commented Oct 5, 2021

@nerdkid93 Yes, we should notify this change with release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants