Add keyboard support to inkview #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
reviewed
Apr 15, 2025
| @@ -110,3 +112,11 @@ func PowerOff() { | |||
| func OpenMainMenu() { | |||
| C.OpenMainMenu() | |||
| } | |||
|
|
|||
| func LoadKeyboard() { | |||
There was a problem hiding this comment.
I know the library's docs are basically non-existent at the moment, but could you write a small bit explaining how OpenKeyboard is different from LoadKeyboard? Is it just showing the keyboard?
There was a problem hiding this comment.
As I understood from reverse engineering the default applications, LoadKeyboard specifies which keyboard to use, and you need to specify the language of the keyboard from the standard set. OpenKeyboard displays the on-screen keyboard and tracks its changes.
dennwc
approved these changes
Apr 15, 2025
dennwc
force-pushed
the
add-new-inkview-features
branch
from
c451785 to
6fd450c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
I was using the inkview library and found it to be almost perfect for my needs, but it lacked keyboard support. I've added this functionality to my fork and believe it would be beneficial to include it in the main repository.
Please review the changes and let me know if you have any questions or concerns. I'm happy to discuss and refine the implementation as needed.