Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: globby -> fast-glob regression #56

Closed
therealpecus opened this issue Mar 30, 2020 · 3 comments
Closed

Bug: globby -> fast-glob regression #56

therealpecus opened this issue Mar 30, 2020 · 3 comments

Comments

@therealpecus
Copy link
Contributor

therealpecus commented Mar 30, 2020

Describe the bug
A fresh install fails to build the demo project.

To Reproduce
Steps to reproduce the behavior:

  1. follow the quick start:
mkdir uiengine-demo && cd uiengine-demo && npm init -y
npm install @uiengine/core @uiengine/adapter-html --save-dev
npx uiengine init --demo
npx uiengine build --serve --watch
  1. the build fails with:
🚨  Build failed!

Child page "elements" does not exist for page "patterns".

Here is a list of available child pages:

notably, the list of available child pages is empty.

Expected behavior
The build succeeds

Additional context
Tried a fresh install with Node v10, v12, v13, same results. This did not happen in the past and does not seem to be tied to version 2.6.x. Tried with v2.5.9 and it still breaks. This seems to be a problem with a downward dependency.

EDIT: found the culprit in fast-glob. Version 3.1.1 works fine. version 3.2.2 fails.
Quick workaround:

rm -rf node_modules/fast-glob
npm i fast-glob@3.1.1

Any course of action to avoid this?
Thanks in advance,
Matteo

@therealpecus therealpecus changed the title Build unexpectedly fails with Child page "elements" does not exist for page Bug: globby -> fast-glob regression Mar 31, 2020
@dennisreimann
Copy link
Owner

Hey Matteo, thanks for reporting and documenting the issue. I know @naltatis also came across this. I'd like to fix it be referencing a fixed fast-glob version, but there is nothing published yet.

Any course of action to avoid this?

For now I recommend to add fast-glob@3.1.1 as a dependency for you app, so that you do not have to rely on a new UIengine release fixing this.

Nevertheless I'll see what I can do with the next regular update I'm trying to publish soon.

@therealpecus
Copy link
Contributor Author

Thanks Dennis,

it seems to have broken havoc in quite some places!
Adding a stable version of fast-glob seems the best choice.

Looking forward to the next update! 🎸

dennisreimann added a commit that referenced this issue Apr 22, 2020
dennisreimann added a commit that referenced this issue Apr 22, 2020
@dennisreimann
Copy link
Owner

The freshly released v3.0.0 contains a fix for this problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants