better handling of SIGINT / Ctrl-C #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwang1498
force-pushed
the
signal-handling
branch
from
e896500 to
a780a8e
Compare
This change ignores SIGINT only for the pipeline elements downstream of ping. This way ping will correctly receive the SIGINT, print its summary and cleanly exit, and then downstream elements will cleanly close afterwards.
xwang1498
force-pushed
the
signal-handling
branch
from
a780a8e to
0f05681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for handling SIGINT / Ctrl-C is a little complicated and doesn't always seem to work right.
For example, if ping is not printing any output then Ctrl-C will sometimes fail to stop the script. You'll need to use something more aggressive like SIGQUIT Ctrl-\ to kill it. Several flavors of ping (iputils-ping, busybox-ping) do not print anything if the host is not responding, or you can reproduce this with
prettyping --pingbin tail -F /dev/null.This change ignores SIGINT only for the pipeline elements downstream of ping. This way ping will correctly receive the SIGINT, print its summary and cleanly exit, and then downstream elements will cleanly close afterwards.
(Minor: this change also unsets the color after printing an rtt bar or missing !, so that the colors don't leak if the script is forcibly killed, e.g. with Ctrl-\ )
This might fix #40, but I can't reproduce @danielb2's specific issue.