Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a breaking change that removes the den and flake-aspects dependencies from the dendritic flake module, simplifying it to a pure flake-parts based setup. The change reduces complexity by removing two external dependencies while maintaining core dendritic functionality through flake-parts and import-tree.
Key Changes
- Removed
denandflake-aspectsas automatic dependencies from the dendritic module - Added
flake.modules = { }initialization to support the flake-parts modules system - Updated documentation with a migration note directing users to den's own dendritic module if they need the removed functionality
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/dendritic/flake.nix | Removed den and flake-aspects input declarations from the dendritic template |
| modules/dendritic/dendritic.nix | Removed imports of flake-aspects and den flake modules, removed their input configurations, and added empty flake.modules initialization |
| dev/flake.nix | Removed den and flake-aspects inputs from the development flake |
| dev/flake.lock | Removed lock entries for den and flake-aspects, updated dependency hashes for devshell, flake-parts, import-tree, nix-unit, nixpkgs, and treefmt-nix, added nix-github-actions as a new transitive dependency |
| README.md | Added important note documenting the breaking change and migration path for users who need the removed functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Related denful/den#59