fix: surface errors to user if bad frontmatter

dendronhq · Jul 17, 2020 · 03107f4 · 03107f4
1 parent abcc367
commit 03107f4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/engine-server/src/drivers/file/store.ts b/packages/engine-server/src/drivers/file/store.ts
@@ -90,6 +90,11 @@ export class FileStorage extends FileStorageBase implements DEngineStore {
   files2Notes(fpaths: string[]): NoteRawProps[] {
     const fp = new FileParser(this, { errorOnEmpty: false });
     const data = fp.parse(fpaths);
+    const errors = fp.errors;
+    const badParseErrors = errors.filter((e) => e.status === "BAD_PARSE");
+    if (!_.isEmpty(badParseErrors)) {
+      throw Error(`bad yaml: ${badParseErrors}`)
+    }
     return data.map((n) => n.toRawProps());
   }
 

diff --git a/packages/plugin-core/src/workspace.ts b/packages/plugin-core/src/workspace.ts
@@ -576,6 +576,7 @@ export class DendronWorkspace {
     }
     VSCodeUtils.openWS(path.join(rootDir, DENDRON_WS_NAME));
   }
+
 
   async reloadWorkspace(mainVault?: string) {
     // TODO: dispose of existing workspace
@@ -585,9 +586,13 @@ export class DendronWorkspace {
       mainVault = wsFolders![0].uri.fsPath;
     }
     const engine = DendronEngine.getOrCreateEngine({ root: mainVault });
-    await engine.init();
-    this._engine = engine;
-    return;
+    try {
+      await engine.init();
+      this._engine = engine;
+      return;
+    } catch (err) {
+      vscode.window.showErrorMessage(`error initializing dendron: ${JSON.stringify(err)}`);
+    }
   }
 
   /**