Skip to content

Commit

Permalink
Add Pending and Remote class files to source control
Browse files Browse the repository at this point in the history
These classes are empty subclasses of Throwable. Only the name has value. These
should be Java 1 compatible, no need to recompile them on the user machine.
  • Loading branch information
ggeoffrey committed Jun 9, 2022
1 parent 9f1fd33 commit 6197ee1
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 10 deletions.
4 changes: 1 addition & 3 deletions Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ It's called Photon because every point in a Photon form can be thought of as sim
```bash
git clone ...
cd photon
clojure -T:build compile-java

# Sanity check that it's working:
clj -A:dev -X user/main # healthcheck app http://localhost:8080
Expand Down Expand Up @@ -146,6 +145,5 @@ Photon/Missionary interop:

* `Execution error (ClassNotFoundException) hyperfiddle.photon.Pending` - run the Clojure build step, see setup instructions
* Cursive says `Dependency cycle: hyperfiddle.api -> hyperfiddle.hfql -> hyperfiddle.hfql.impl -> hyperfiddle.api` – Cursive is not correctly handling Clojure 1.11 :as-alias, load the file form by form instead
* `clojure -T:build compile-java` error `-T is no longer supported, use -A with repl, -M for main, or -X for exec` – clojure CLI is not up to date, `brew upgrade clojure`. If you can't update, try `clojure -A:build -X build/compile-java`
* :eval opcode - probably interop syntax, or a macro like assert that expands to interop syntax
* `Unbound var.` Usually means wrong peer, i.e. accessed server-only var on client
* `Unbound var.` Usually means wrong peer, i.e. accessed server-only var on client
6 changes: 1 addition & 5 deletions deps.edn
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{:paths ["src" "target/classes"]
{:paths ["src"]
:deps {org.clojure/clojure {:mvn/version "1.11.1"}
missionary/missionary {:mvn/version "b.27-SNAPSHOT"}
hyperfiddle/rcf {:git/url "https://github.com/hyperfiddle/rcf"
Expand Down Expand Up @@ -31,10 +31,6 @@
org.clojure/tools.logging {:mvn/version "1.2.4"}
}

:deps/prep-lib {:ensure "target/classes"
:alias :build
:fn compile-java}

:aliases {:build {:extra-paths ["src-dev"]
:deps {io.github.clojure/tools.build {:git/tag "v0.8.2" :git/sha "ba1a2bf"}}
:ns-default build}
Expand Down
4 changes: 2 additions & 2 deletions src-dev/build.clj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

(defn compile-java [_]
(b/javac {:src-dirs ["src"]
:class-dir "target/classes"
:class-dir "src"
:basis (b/create-basis {:project "deps.edn"})
:javac-opts ["-source" "8" "-target" "8"]}))
:javac-opts ["-source" "8" "-target" "8"]}))
Binary file added src/hyperfiddle/photon/Pending.class
Binary file not shown.
Binary file added src/hyperfiddle/photon/Remote.class
Binary file not shown.

0 comments on commit 6197ee1

Please sign in to comment.