Destroy EditorFilesystem/EditorSettings on test shutdown

Otherwise asan complains if a test tries to use these. Split off from godotengine#98909
demolke · Nov 30, 2024 · 30a8c93 · 30a8c93
1 parent c7198dd
commit 30a8c93
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/editor/editor_file_system.cpp b/editor/editor_file_system.cpp
@@ -3556,5 +3556,9 @@ EditorFileSystem::EditorFileSystem() {
 }
 
 EditorFileSystem::~EditorFileSystem() {
+	if (filesystem) {
+		memdelete(filesystem);
+	}
+	filesystem = nullptr;
 	ResourceSaver::set_get_resource_id_for_path(nullptr);
 }
diff --git a/editor/editor_paths.cpp b/editor/editor_paths.cpp
@@ -105,6 +105,7 @@ void EditorPaths::create() {
 void EditorPaths::free() {
 	ERR_FAIL_NULL(singleton);
 	memdelete(singleton);
+	singleton = nullptr;
 }
 
 void EditorPaths::_bind_methods() {

diff --git a/tests/test_main.cpp b/tests/test_main.cpp
@@ -369,6 +369,9 @@ struct GodotTestCaseListener : public doctest::IReporter {
 		if (EditorSettings::get_singleton()) {
 			EditorSettings::destroy();
 		}
+		if (EditorPaths::get_singleton()) {
+			EditorPaths::free();
+		}
 #endif // TOOLS_ENABLED
 
 		Engine::get_singleton()->set_editor_hint(false);