Devo_v2 initial version with enhanced functionality - #5510
Merged
Conversation
…lude fetching alerts, running multi-table queries, writing back to Devo tables. Please refer to README.md for all features.
Devo_v2.yml:
- Moved proxy to end of list
- Changed the types of the JSON filters to long test.
Devo_v2.py:
- Renamed check_credentials to check_configuration and supported more config value checks when using test
- Added in get_time_range to support multiple datetime formats.
- Added in functionality to ignore insecure connections if setting is toggled.
- Wraped socket logic in try/finally block
- Return actual contents that are written instead of length of written contents.
Devo_v2_description:
- Additional integration configuration documentation along with expected values. Also links to Devo Docs.
README.md:
- Additional information on newly supported date formats as well as enhanced documentation to Devo.
Devo_v2_test.py:
- Fixed test for check_configuration.
- Added in test for get_time_range.
…o trust any certificate (not secure)
… true -> false and no default value so that insecure logic works correctly
Devo_v2 initial version with enhanced functionality
yaakovi
approved these changes
Jan 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Features now include fetching alerts, running multi-table queries, writing back to Devo tables. Please refer to README.md for all features. Refer to previous PR in related issues as
Status
Ready
Related Issues
#4419
Description
A new and updated Devo_v2 integration with enhanced functionality. Uses our new APIs and offers automated incident creation of alerts generated in Devo.
Screenshots
Required version of Demisto
5.0.0+
Does it break backward compatibility?
Must have
Dependencies
Mention the dependencies of the entity you changed as given from the precommit hooks in checkboxes, and tick after tested them.
Additional changes
Completely new integration
Technical writer review
Mention and link to the files that require a technical writer review.