Skip to content

Get asset details split xsiam/platform versions #40917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Get asset details split xsiam/platform versions #40917

wants to merge 9 commits into from
+23 −3

Conversation

itssapir
Copy link
Contributor

@itssapir itssapir commented Aug 12, 2025 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-14470

Description

Removed Cortex Core - Platform from XSIAM and un-deprecated core-get-asset-details for XSIAM in the Investigation & Response integration.

Must have

  • Tests
  • Documentation

@itssapir itssapir requested a review from omerKarkKatz August 12, 2025 13:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py3123688%59–62, 64, 66, 69, 76, 78, 81, 84, 96, 99, 173, 186–187, 223–225, 227, 269, 367, 384, 536–537, 540–543, 545–546, 608, 635–636, 781, 805
Packs/Core/Integrations/CortexPlatformCore
   CortexPlatformCore.py25772%18–21, 23, 25, 55
TOTAL3374387% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 0 🔥 1.997s ⏱️

@itssapir itssapir added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 17, 2025
@richardbluestone
Copy link
Contributor

Docs look good

omerKarkKatz
omerKarkKatz reviewed Aug 18, 2025
View reviewed changes
Packs/Core/Integrations/CortexPlatformCore/CortexPlatformCore.yml
@@ -68,14 +68,17 @@ script:
script: '-'
subtype: python3
type: python
dockerimage: demisto/google-cloud-storage:1.0.0.2941324
dockerimage: demisto/google-cloud-storage:1.0.0.4088897
tests:
- No tests
fromversion: 6.2.0
supportedModules:
- C1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt we say we will remove all the modules from here?

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: BC108.
The following errors cannot be ignored: BC108.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: BC108.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerKarkKatz omerKarkKatz omerKarkKatz left review comments

@jlevypaloalto jlevypaloalto Awaiting requested review from jlevypaloalto jlevypaloalto is a code owner

@richardbluestone richardbluestone Awaiting requested review from richardbluestone

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itssapir @richardbluestone @content-bot @omerKarkKatz