Skip to content

Fix/XSUP-54524/Add CIDR support for ThreatConnect #40899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 12, 2025

Conversation

MosheEichler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

According this docs we need to add the Block key to the payload.

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Aug 11, 2025
@MosheEichler MosheEichler added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 11, 2025
Copy link

github-actions bot commented Aug 11, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ThreatConnect/Integrations/ThreatConnectV3
   ThreatConnectV3.py4758781%114, 120, 130, 138, 141–143, 148–149, 155–156, 158, 163, 165–168, 171, 178–181, 197, 201–203, 210–211, 272, 293, 375–381, 455, 460–462, 471–472, 479, 514–515, 709, 775, 780–781, 783–784, 836–837, 850–851, 865, 867, 877, 1915, 2002–2006, 2156–2160, 2271–2275, 2297, 2322–2332
TOTAL4758781% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 2.504s ⏱️

@richardbluestone
Copy link
Contributor

Docs review done

@MosheEichler MosheEichler enabled auto-merge (squash) August 11, 2025 13:11
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: RN111.
The following errors cannot be ignored: RN111.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN111.

Verdict: PR can be force merged from validate perspective? ✅

@MosheEichler MosheEichler merged commit f156e68 into master Aug 12, 2025
17 of 18 checks passed
@MosheEichler MosheEichler deleted the Add-CIDR-support-for-ThreatConnect branch August 12, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants