Skip to content

XSUP-54350 getServerURL extend context does not work with return_outputs() #40880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 11, 2025
Merged

XSUP-54350 getServerURL extend context does not work with return_outputs() #40880

merged 11 commits into from
Aug 11, 2025

Conversation

BarGali
Copy link
Contributor

@BarGali BarGali commented Aug 10, 2025

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-54350

Description

Updated the GetServerURL script to use return_results.

Must have

  • Tests
  • Documentation

@BarGali BarGali requested a review from BEAdi August 10, 2025 11:40
@BarGali BarGali self-assigned this Aug 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 10, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/GetServerURL
   GetServerURL.py120100% 
TOTAL120100% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 0 🔥 2.211s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.97.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

BEAdi
BEAdi approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BarGali @BEAdi
Update Packs/CommonScripts/ReleaseNotes/1_19_97.md
374a3d3 
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
@BarGali BarGali added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 11, 2025
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.98.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@richardbluestone richardbluestone removed their request for review August 11, 2025 11:15
@richardbluestone richardbluestone removed their assignment Aug 11, 2025
@richardbluestone richardbluestone requested review from richardbluestone and removed request for julieschwartz18 August 11, 2025 12:36
richardbluestone
richardbluestone approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@richardbluestone richardbluestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review done

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.99.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@BarGali BarGali merged commit d4c870a into master Aug 11, 2025
18 checks passed
@BarGali BarGali deleted the bg-XSUP-54350-getServerURL branch August 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardbluestone richardbluestone richardbluestone approved these changes

@BEAdi BEAdi BEAdi approved these changes

Assignees

@richardbluestone richardbluestone

@BarGali BarGali

Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BarGali @content-bot @richardbluestone @BEAdi @julieschwartz18