Skip to content

Add commands list requests request approve request deny #40849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 14, 2025
Merged

Add commands list requests request approve request deny #40849

merged 22 commits into from
Aug 14, 2025

Conversation

thefrieddan1
Copy link
Contributor

Related Issues

fixes: link to the issue

Description

Add commands list requests request approve request deny

@thefrieddan1 thefrieddan1 requested a review from DeanArbel August 6, 2025 13:53
@thefrieddan1 thefrieddan1 self-assigned this Aug 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AdminByRequest/Integrations/AdminByRequestEventCollector
   AdminByRequestEventCollector.py2083583%87–89, 93–95, 99, 188–189, 191–193, 195, 357–360, 362, 401, 403, 407–410, 414–422, 459, 491
TOTAL2083583% 

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 2.382s ⏱️

@thefrieddan1 thefrieddan1 marked this pull request as ready for review August 6, 2025 16:06
@thefrieddan1 thefrieddan1 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 6, 2025
@richardbluestone
Copy link
Contributor

Doc review done

@thefrieddan1 thefrieddan1 requested a review from DeanArbel August 14, 2025 10:40
DeanArbel
DeanArbel approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please be sure to update the description to account for the 100k hard limit.

@thefrieddan1
docs: clarify all_results parameter limit of 100,000 in AdminByReques…
9d79add 
…t integration
@thefrieddan1
Merge branch 'add-commands-list-requests_request-approve_request-deny…
96c7be7 
…' of github.com:demisto/content into add-commands-list-requests_request-approve_request-deny
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@thefrieddan1 thefrieddan1 merged commit 8afe128 into master Aug 14, 2025
18 checks passed
@thefrieddan1 thefrieddan1 deleted the add-commands-list-requests_request-approve_request-deny branch August 14, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardbluestone richardbluestone richardbluestone left review comments

@DeanArbel DeanArbel DeanArbel approved these changes

Assignees

@thefrieddan1 thefrieddan1

@richardbluestone richardbluestone

Labels
docs-approved post-demo ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thefrieddan1 @richardbluestone @content-bot @DeanArbel