Skip to content

Update TrendMicroVisionOneV3.yml #40805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025

Conversation

tpi007
Copy link
Contributor

@tpi007 tpi007 commented Aug 4, 2025

update new version of pytmv1

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

update new version of pytmv1
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2025

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Aug 4, 2025
@content-bot content-bot changed the base branch from master to contrib/tpi007_master August 4, 2025 03:10
@content-bot content-bot requested a review from merit-maita August 4, 2025 03:10
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @tpi007, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution
please make sure to fill the contribution form
in addition to that, updating the yml or py file requires adding Release note, so please do with the note that says:

  • Updated the Docker image to demisto/pytmv1:0.9.2.4398531.

@merit-maita merit-maita added the pending-contributor The PR is pending the response of its creator label Aug 4, 2025
@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Aug 5, 2025
@tpi007
Copy link
Contributor Author

tpi007 commented Aug 5, 2025

Updated the Docker image to demisto/pytmv1:0.9.2.4398531.

@merit-maita
Copy link
Contributor

Updated the Docker image to demisto/pytmv1:0.9.2.4398531.

sorry i might've not explained it well, Release note is a file created in the pack itself (in the Release notes folder) where the changes of the new version is documented, to create this file run the command:
demisto-sdk update-release-notes -i Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3
then go to the new created file and add the note i sent you.

add release notes
@tpi007
Copy link
Contributor Author

tpi007 commented Aug 6, 2025

Hi @merit-maita
I have add release notes 4_2_8.md file

@merit-maita
Copy link
Contributor

@tpi007 the version needs to be raised in the pack_metadata file as well, to the same version created for the rn file.

update current version into 4.2.8
@tpi007
Copy link
Contributor Author

tpi007 commented Aug 7, 2025

@merit-maita I also updated pack_metadata file

@merit-maita merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Aug 7, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4447195

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Aug 7, 2025
@tpi007
Copy link
Contributor Author

tpi007 commented Aug 11, 2025

Hi @merit-maita
Thanks for your help, but I still find that 3 failing checks in the following:
failing checks
docs-approved label verification / check_label_job (pull_request)
docs-approved label verification / check_label_job (pull_request)Failing after 1m
Required
Partner-Approved label verification / check_label_job (pull_request)
Partner-Approved label verification / check_label_job (pull_request)Failing after 1m
Required
pre-commit / pre-commit / pre-commit (pull_request)
pre-commit / pre-commit / pre-commit (pull_request)Failing after 4m

would U please help check why there are failing, how can i do to by pass these checking.

Thanks

@merit-maita
Copy link
Contributor

Hi @merit-maita Thanks for your help, but I still find that 3 failing checks in the following: failing checks docs-approved label verification / check_label_job (pull_request) docs-approved label verification / check_label_job (pull_request)Failing after 1m Required Partner-Approved label verification / check_label_job (pull_request) Partner-Approved label verification / check_label_job (pull_request)Failing after 1m Required pre-commit / pre-commit / pre-commit (pull_request) pre-commit / pre-commit / pre-commit (pull_request)Failing after 4m

would U please help check why there are failing, how can i do to by pass these checking.

Thanks

im going to handle these failures, it's all good

@merit-maita merit-maita merged commit c296f8c into demisto:contrib/tpi007_master Aug 11, 2025
32 of 39 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

merit-maita added a commit that referenced this pull request Aug 12, 2025
* Update TrendMicroVisionOneV3.yml (#40805)

* Update TrendMicroVisionOneV3.yml

update new version of pytmv1

* Add files via upload

add release notes

* Update pack_metadata.json

update current version into 4.2.8

* fixes

---------

Co-authored-by: david_zhang <david_zhang@trendmicro.com>
Co-authored-by: merit-maita <meretmaayta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants