Skip to content

Added using-brands argument to generic command in get-endpoint-data #40797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Aug 11, 2025
Merged

Added using-brands argument to generic command in get-endpoint-data #40797

merged 46 commits into from
Aug 11, 2025

Conversation

noydavidi
Copy link
Contributor

@noydavidi noydavidi commented Aug 3, 2025 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

This pr is solving the duplication problem and added support to the Generic Command to use using-brand argument.

Must have

  • Tests
  • Documentation

@noydavidi noydavidi changed the title Add microsoft defender ATP command to get-endpoint-data script Added using-brands argument to generic command in get-endpoint-data to use Aug 5, 2025
@noydavidi noydavidi added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 5, 2025
@noydavidi noydavidi marked this pull request as ready for review August 5, 2025 12:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AggregatedScripts/Scripts/GetEndpointData
   GetEndpointData.py2926777%33, 78, 119, 139, 172, 197, 205, 210–211, 218, 263–264, 290–291, 307, 342, 354, 411–414, 416, 418, 435–436, 455, 457, 528, 568, 637–638, 640–641, 650–653, 655, 686, 702, 730, 790, 936–939, 941–943, 982–989, 991–992, 998–1001, 1003, 1005–1006, 1022
TOTAL2926777% 

Tests Skipped Failures Errors Time
39 0 💤 0 ❌ 0 🔥 2.367s ⏱️

@noydavidi noydavidi changed the title Added using-brands argument to generic command in get-endpoint-data to use Added using-brands argument to generic command in get-endpoint-data Aug 5, 2025
@noydavidi noydavidi requested review from Shellyber and YuvHayun August 6, 2025 06:57
@noydavidi noydavidi requested a review from YuvHayun August 10, 2025 08:02
Shellyber
Shellyber reviewed Aug 10, 2025
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.
Let's schedule a 15 minutes call to go over the code together.

@Shellyber
Copy link
Contributor

@julieschwartz18 Please help us review here :)

@noydavidi noydavidi requested a review from Shellyber August 10, 2025 09:59
@noydavidi noydavidi force-pushed the get-endpoint-data-add-microsoft-defender-atp-command branch from 987d334 to d4a9403 Compare August 10, 2025 10:43
julieschwartz18
julieschwartz18 reviewed Aug 10, 2025
View reviewed changes
Copy link
Contributor

@julieschwartz18 julieschwartz18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review complete, I would like to discuss some questions I have, thanks

Shellyber
Shellyber approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix what we talked about

@noydavidi noydavidi force-pushed the get-endpoint-data-add-microsoft-defender-atp-command branch from d611331 to 1ae5774 Compare August 11, 2025 10:10
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@noydavidi noydavidi requested review from julieschwartz18 and removed request for julieschwartz18 August 11, 2025 12:02
@noydavidi noydavidi dismissed YuvHayun’s stale review August 11, 2025 12:39

already reviewed

@noydavidi noydavidi merged commit 793efbe into master Aug 11, 2025
18 checks passed
@noydavidi noydavidi deleted the get-endpoint-data-add-microsoft-defender-atp-command branch August 11, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shellyber Shellyber Shellyber approved these changes

@julieschwartz18 julieschwartz18 julieschwartz18 approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees

@julieschwartz18 julieschwartz18

Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noydavidi @Shellyber @content-bot @YuvHayun @julieschwartz18