Skip to content

Added logos for selected integrations #40790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 12, 2025
Merged

Added logos for selected integrations #40790

merged 15 commits into from
Aug 12, 2025

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Aug 3, 2025 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
related: gitlab mr 1106

Example:
image
image

image

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url labels Aug 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2025

Your contributed CheckPointNDR pack has been modified on files:

Packs/CheckPointNDR/Integrations/CheckPointNDR/CheckPointNDR_dark.svg
Please review the changes here

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2025

Your contributed FeedReversingLabsRansomwareAndRelatedToolsApp pack has been modified on files:

Packs/FeedReversingLabsRansomwareAndRelatedToolsApp/Integrations/ReversingLabsRansomwareAndRelatedToolsFeed/ReversingLabs Ransomware and Related Tools Feed_dark.svg
Please review the changes here

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2025

Your contributed IdentityRecordedFuture pack has been modified on files:

Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/Recorded Future Identity_dark.svg
Please review the changes here

@michal-dagan michal-dagan changed the title added new images Added logos for selected integrations Aug 5, 2025
@michal-dagan michal-dagan marked this pull request as ready for review August 6, 2025 11:09
@michal-dagan michal-dagan requested a review from dantavori August 6, 2025 11:10
michal-dagan
michal-dagan commented Aug 6, 2025
View reviewed changes
michal-dagan
michal-dagan commented Aug 6, 2025
View reviewed changes
@michal-dagan michal-dagan added the ForceMerge Forcing the merge of the PR despite the build status label Aug 11, 2025
@michal-dagan
Copy link
Contributor Author

@dantavori - Force merge – the failures are unrelated to the newly added images
#40790 (comment)

dantavori
dantavori approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can avoid spaces in the file names? It’s generally less recommended. I’d name each one the same as the yml file.

@github-actions GitHub Actions
Copy link

Your contributed RecordedFuture pack has been modified on files:

Packs/RecordedFuture/Integrations/RecordedFutureLists/RecordedFutureLists_dark.svg
Please review the changes here

@github-actions GitHub Actions
Copy link

Your contributed ReversingLabs_A1000 pack has been modified on files:

Packs/ReversingLabs_A1000/Integrations/ReversingLabsA1000/ReversingLabsA1000_dark.svg
Please review the changes here

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: RN106, DS104, GR107, ST111, DO106, DS108, PA114.
The following errors can be ignored: GR107, DS108.
The following errors cannot be ignored: RN106, DS104, ST111, DO106, PA114.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN106, DS104, GR107, ST111, DO106, DS108, PA114.

Verdict: PR can be force merged from validate perspective? ✅

@michal-dagan
Copy link
Contributor Author

@dantavori - Force merge – the failures are unrelated to the newly added images
#40790 (comment)

@dantavori dantavori merged commit e91f194 into master Aug 12, 2025
19 of 22 checks passed
@dantavori dantavori deleted the add-svg-images-new branch August 12, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

@jlevypaloalto jlevypaloalto Awaiting requested review from jlevypaloalto jlevypaloalto is a code owner

Assignees
No one assigned
Labels
bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-dagan @content-bot @dantavori