Skip to content

Fix Python 3.12 compatibility by replacing deprecated distutils.util.strtobool #40759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 17, 2025

Conversation

shmuel44
Copy link
Contributor

Description

This PR fixes Python 3.12 compatibility issues by replacing the deprecated distutils.util.strtobool function, which was removed in Python 3.12.

Copy link

Your contributed Claroty pack has been modified on files:

Packs/Claroty/pack_metadata.json
Packs/Claroty/ReleaseNotes/1_0_30.md
Packs/Claroty/Integrations/Claroty/Claroty.yml
Packs/Claroty/Integrations/Claroty/Claroty.py
Please review the changes here

@shmuel44 shmuel44 requested a review from BEAdi July 29, 2025 10:01
@shmuel44 shmuel44 self-assigned this Jul 29, 2025
@shmuel44 shmuel44 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Jul 29, 2025
Copy link

github-actions bot commented Jul 29, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py478280783%141–144, 155, 157, 491, 533, 629, 655–659, 684, 699, 841–842, 851, 892–893, 911, 941–945, 949–951, 993, 1080–1088, 1132–1137, 1171–1173, 1303–1307, 1310–1311, 1313–1315, 1329–1331, 1333, 1399, 1412, 1425, 1433–1435, 1437, 1450, 1458, 1560–1561, 1616, 1638–1639, 1642, 1648, 1650, 1652, 1757, 1803, 1877–1878, 1882–1883, 1922–1923, 1937–1942, 1944, 2012, 2095, 2097, 2134, 2164, 2168, 2210, 2390, 2414, 2453–2454, 2534–2535, 2537, 2550–2557, 2559, 2636–2638, 2652, 2665, 2702–2706, 2708–2710, 2712, 2716–2717, 2719, 2732–2738, 2742, 2746–2748, 2754–2755, 2767, 2795, 2798, 2803, 2823, 2829, 2831, 2833, 2853, 2856, 2868, 2914–2922, 2924, 2983, 3005, 3025, 3083, 3095–3096, 3208, 3210, 3412, 3422, 3428, 3437, 3443, 3457, 3513, 3522, 3525, 3528, 3531, 3534, 3537, 3546, 3548, 3553–3554, 3585–3590, 3593, 3644–3645, 3648, 3814–3815, 3818, 3925, 3928, 4179, 4182, 4185, 4188, 4193, 4202, 4228, 4234, 4237, 4243, 4246, 4249, 4252, 4255, 4264, 4266, 4382–4383, 4407, 4409, 4428, 4431, 4434, 4502, 4523, 4525, 4687, 4705, 4717, 4747, 4750, 4756, 4759, 4762, 4771, 4773, 4973–4974, 4993, 4996, 4999, 5002, 5008, 5070, 5072, 5097, 5112–5128, 5131, 5135–5136, 5138–5139, 5141–5142, 5144–5145, 5147–5148, 5150–5151, 5153–5154, 5156–5157, 5159–5160, 5162–5163, 5165–5166, 5168–5169, 5171–5172, 5174, 5176–5177, 5179–5182, 5184–5186, 5188, 5190, 5194, 5270, 5310, 5316, 5318, 5328, 5366, 5371–5372, 5377, 5381–5382, 5384, 5466, 5472, 5565, 5586, 5589–5594, 5602–5608, 5610–5611, 5656, 5669, 5765–5768, 5773, 5776, 5779, 5813, 5816, 5860, 5862, 5864, 5959, 6010, 6092, 6104, 6122, 6162–6163, 6167, 6169, 6203, 6207, 6209, 6211, 6213, 6259, 6263, 6362–6365, 6367, 6380, 6399, 6409, 6415, 6424–6426, 6429–6432, 6447, 6489, 6518, 6521, 6580–6590, 6593, 6603–6604, 6606–6607, 6609–6610, 6615, 6619–6620, 6622, 6659–6662, 6665–6669, 6673, 6681, 6687, 6715, 6744, 6750–6751, 6802, 6822–6823, 6825, 6865–6866, 6873, 6878, 6884, 6897–6898, 6900, 7171–7173, 7192, 7205, 7217, 7245, 7409, 7425, 7490, 7518, 7524, 7566–7567, 7579, 7594–7595, 7597–7598, 7600–7601, 7603–7604, 7606–7609, 7611, 7613–7614, 7616, 7695–7696, 7708, 7752–7755, 7757, 7764–7765, 7925, 7980, 8016, 8036, 8038, 8139, 8299–8302, 8304–8306, 8365, 8384–8385, 8397, 8413, 8434–8435, 8437, 8454, 8541, 8555, 8558–8561, 8564, 8567, 8589–8592, 8689, 8708–8709, 8828, 8843, 8860–8862, 8898–8900, 8910–8911, 8929, 8961, 9017, 9021–9022, 9036, 9039, 9052–9054, 9057, 9129, 9299–9300, 9380–9381, 9425–9426, 9428, 9431, 9442, 9448–9451, 9453, 9455, 9457–9458, 9574, 9699, 9713, 9716, 9920, 9929, 9995–9996, 10000, 10061–10064, 10066, 10088, 10100, 10196, 10232–10233, 10246, 10259–10264, 10280–10281, 10289–10290, 10303, 10311–10312, 10329–10330, 10344, 10354, 10370, 10381, 10389–10391, 10393, 10419, 10434, 10445, 10463–10464, 10467, 10485, 10488, 10503, 10517, 10523, 10538, 10555, 10567–10575, 10578–10579, 10581, 10596–10598, 10609, 10612, 10701, 10727, 10734, 10778, 10804–10805, 10848, 10850–10852, 10854, 10929, 10938, 11059, 11123, 11127–11128, 11219–11224, 11320–11323, 11395–11398, 11400, 11449–11450, 11455–11456, 11473, 11559–11561, 11580, 11792, 11909, 11933, 11956, 11981, 11988–11994, 11996, 11998, 12099, 12102, 12155, 12206–12207, 12209–12216, 12221–12223, 12225, 12227, 12342–12343, 12362, 12400–12401, 12405, 12434–12442, 12444–12445, 12466, 12469, 12471–12472, 12474, 12476, 12478, 12480–12483, 12485, 12487–12488, 12492–12494, 12527, 12591–12592, 12594, 12602, 12611, 12615, 12617–12619, 12622–12623, 12626–12629, 12632, 12635, 12638–12645, 12647, 12658–12661, 12664, 12666–12670, 12672–12674, 12676, 12755, 12771, 12776–12777, 12779, 12799, 12805, 12835, 12848, 12858–12860, 12873–12875, 12888–12897
Packs/Claroty/Integrations/Claroty
   Claroty.py39320847%119–121, 123, 125, 136, 149–150, 152, 155, 168, 171–173, 203–207, 217, 221–223, 225–227, 229, 233–234, 236, 238–241, 243–245, 247–249, 251–253, 255, 257–260, 262–263, 265–266, 268–269, 273–279, 281, 283, 285–286, 288–290, 292, 294–296, 298, 302–305, 307–309, 313–314, 316–325, 327–329, 331–333, 335–336, 338–340, 342–344, 346–347, 349–351, 355–356, 358–359, 365, 367–369, 371–372, 374–375, 377, 379, 384, 439–443, 445–450, 470–473, 480–484, 498, 502–506, 508–512, 514–515, 519, 527–530, 538–539, 541, 545–549, 558, 562, 567–572, 577, 632, 643–644, 646, 648, 650, 652, 654–656, 663–665, 667–668, 670–671, 673–674, 676–677, 679–680, 682–683, 685–686
Packs/Gmail/Integrations/Gmail
   Gmail.py130178239%62–64, 67–70, 73–74, 77–80, 83–86, 89–90, 93–95, 97–98, 101, 105–111, 116–124, 131, 146–150, 152–156, 160–165, 253, 261, 299, 348, 354, 415–419, 446, 474, 478, 491, 506, 552–554, 557, 560–562, 564, 621, 844–850, 854–855, 857–860, 862, 866–867, 869, 873, 875–879, 887–889, 893, 900–903, 905–906, 912–915, 917–921, 923, 927–930, 932–934, 936, 946–956, 958, 961, 965–968, 983, 994–995, 997–999, 1003–1007, 1009–1010, 1014, 1019–1020, 1022–1023, 1025, 1029–1032, 1034, 1038, 1045–1046, 1048, 1052–1056, 1060, 1067–1068, 1070, 1074–1075, 1077, 1079, 1083, 1085, 1096–1097, 1101, 1103–1117, 1119, 1131, 1145, 1159–1160, 1162, 1165–1166, 1170–1173, 1177–1180, 1184, 1187–1188, 1195–1196, 1199, 1201–1202, 1206–1210, 1212–1213, 1215–1216, 1220, 1230–1231, 1233, 1237–1238, 1240, 1244, 1248–1249, 1251, 1255–1258, 1262–1264, 1266–1267, 1269–1270, 1274, 1279, 1287, 1289, 1291, 1295, 1297, 1306, 1310–1312, 1314–1315, 1317–1318, 1322, 1324–1325, 1327–1328, 1332, 1337–1338, 1340–1341, 1345–1347, 1349, 1351, 1355, 1359–1360, 1362, 1373–1380, 1382–1385, 1389–1392, 1394–1396, 1399–1400, 1403, 1406–1409, 1414, 1417–1419, 1424–1425, 1432, 1434–1442, 1444–1451, 1453–1456, 1474–1477, 1480–1487, 1508, 1518–1519, 1521, 1529, 1531–1535, 1537, 1540–1541, 1543, 1545, 1549–1553, 1555–1561, 1565, 1570–1571, 1574, 1576, 1580–1582, 1584, 1586, 1590, 1595–1597, 1599, 1603–1609, 1613–1617, 1619–1620, 1624, 1632–1633, 1635, 1639–1642, 1644, 1646–1647, 1652, 1655, 1661–1662, 1665, 1667, 1671–1674, 1676, 1680, 1685, 1691–1693, 1695–1696, 1700, 1702–1704, 1706, 1708, 1712, 1714–1715, 1717, 1721, 1723–1725, 1727, 1735, 1739, 1741–1754, 1756, 1770, 1786, 1794–1813, 1815–1816, 1818, 1822, 1824–1827, 1829, 1831, 1835, 1838–1842, 1844, 1848, 1850–1853, 1855–1856, 1858, 1862, 1864–1865, 1867, 1877–1878, 1898–1899, 1906–1907, 1912, 1916–1917, 1919–1920, 1922–1923, 1925–1928, 1930–1932, 1934, 1936, 1938, 1980–1984, 1986–1989, 1991–1993, 1995, 1999–2000, 2004–2006, 2008–2012, 2014–2016, 2018–2019, 2021, 2023, 2030–2037, 2040, 2042–2044, 2046, 2048–2051, 2054–2055, 2062–2067, 2070–2071, 2073–2079, 2082–2083, 2085–2089, 2092–2093, 2095–2099, 2101–2102, 2105–2109, 2112–2113, 2140–2144, 2149, 2152, 2158–2161, 2180, 2182, 2186–2187, 2189–2194, 2198–2200, 2202–2204, 2206–2207, 2210–2212, 2232–2233, 2237–2257, 2259, 2282, 2284–2286, 2291–2292, 2296–2298, 2300, 2313–2324, 2345–2346, 2363, 2387–2397, 2399, 2422–2423, 2445, 2472–2473, 2475, 2477, 2479, 2481–2485, 2487–2490, 2492–2493, 2495, 2497, 2505, 2532, 2543–2544, 2579–2581, 2606–2607, 2618–2619, 2666–2667, 2671, 2681, 2692–2694, 2698–2700, 2709, 2723–2724
Packs/PhishLabs/Scripts/PhishLabsPopulateIndicators
   PhishLabsPopulateIndicators.py584424%34–40, 42–53, 55, 57–58, 60–62, 64, 66–69, 76–77, 79–83, 85, 94–96, 98–99, 101
Packs/SymantecManagementCenter/Integrations/SymantecManagementCenter
   SymantecManagementCenter.py59838036%52, 58, 61–72, 76–79, 88, 94, 99–109, 121–122, 130–139, 141, 143–145, 147–148, 157–158, 161, 163, 165, 181–182, 184–197, 199–200, 208–210, 212–214, 231, 233, 250, 265, 267, 269, 277–280, 282–284, 286–290, 300–302, 309–311, 314, 316, 318, 320, 329, 331, 333, 341–344, 346–349, 351, 358–359, 368–370, 377–379, 382, 384, 386, 395, 397, 399, 407–409, 411–413, 423, 425, 427, 442, 444, 446, 454–462, 464, 466–468, 470–471, 483–484, 487, 489, 491, 505–506, 508–519, 521–522, 530–539, 541–542, 544, 546–548, 555, 557–559, 566–572, 575–581, 584–590, 592–593, 600–604, 608–610, 614, 616–617, 626, 628, 630, 651–657, 659–660, 662–664, 671, 673, 675, 694, 696, 698–707, 709–710, 718–722, 724–725, 727–729, 736, 738, 740, 757, 759, 761–768, 770–771, 779–780, 782–783, 793, 795–796, 820, 824, 828, 868, 872, 876, 880, 893–897, 900–904, 909–912, 946, 948, 950, 960, 980, 984, 994, 997, 1022–1032, 1035, 1060, 1067, 1077, 1134, 1139, 1156–1173, 1189–1191, 1193, 1195–1197, 1199–1200, 1209–1210, 1213, 1215, 1217, 1226–1227, 1229–1230
Packs/Syslog/Integrations/SyslogSender
   SyslogSender.py2146967%75–76, 83–86, 95–99, 102, 104, 114, 116–119, 157–159, 161–166, 168–169, 172–173, 178, 236, 238, 240, 259, 261, 263, 275, 303–304, 310, 317, 321, 330, 333–335, 338, 359–362, 364, 368, 372–380, 386–387, 392–393, 397
TOTAL7346229068% 

Tests Skipped Failures Errors Time
5648 88 💤 0 ❌ 0 🔥 4m 42s ⏱️

Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, just update the RN

Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@richardbluestone richardbluestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@shmuel44 shmuel44 added the ForceMerge Forcing the merge of the PR despite the build status label Aug 17, 2025
@shmuel44
Copy link
Contributor Author

HI @yuvalbenshalom, this PR needs a force merge as the gmail test playbooks failed due to missing creds

@yuvalbenshalom yuvalbenshalom merged commit c7a8aa6 into master Aug 17, 2025
21 of 22 checks passed
@yuvalbenshalom yuvalbenshalom deleted the sk_strtobool_python_3_12 branch August 17, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants