Cyberwatch integration 1.0.4 #40695
Cyberwatch integration 1.0.4 #40695
Conversation
content-bot
added
Partner-Approved
Contribution Form Filled
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed. |
|
Hi @tarraschk, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
merit-maita
added
the
pending-contributor
|
@tarraschk any update? |
Hello @merit-maita thank you for your message. @AmineHazi should be able to make a new push this week. |
|
@tarraschk any update? |
|
|
|
Hello @merit-maita, sorry for the late update, the issues should be all fixed in the new commits ! let me know if there are other changes that you would like me to do, have a nice day. |
There was a problem hiding this comment.
thanks for the update, i added just a couple of comments, more to that, let's set up a demo, feel free to contact me over slack DFIR (merit maayta) or by mail (mmaayta@paloaltonetworks.com) to set a call
| assets = client.get_sysadmin_assets(args) | ||
|
|
||
| if len(assets) == 0: | ||
| return demisto.results("No Sysadmin assets found.") |
There was a problem hiding this comment.
we no longer use demisto.results() please use return_results
| return demisto.results("No Sysadmin assets found.") | |
| return_results("No Sysadmin assets found.") |
| asset = client.get_sysadmin_one_asset(args) | ||
|
|
||
| if len(asset) == 0: | ||
| return demisto.results(f"Sysadmin asset with {args.get('id')} not found.") |
There was a problem hiding this comment.
| return demisto.results(f"Sysadmin asset with {args.get('id')} not found.") | |
| return_results(f"Sysadmin asset with {args.get('id')} not found.") |
| asset = client.get_compliance_one_asset(args) | ||
|
|
||
| if len(asset) == 0: | ||
| return demisto.results(f"Compliance asset with {args.get('id')} not found.") |
There was a problem hiding this comment.
| return demisto.results(f"Compliance asset with {args.get('id')} not found.") | |
| return_results(f"Compliance asset with {args.get('id')} not found.") |
| assets = client.get_compliance_assets(args) | ||
|
|
||
| if len(assets) == 0: | ||
| return demisto.results("No Compliance assets found.") |
There was a problem hiding this comment.
| return demisto.results("No Compliance assets found.") | |
| return_results("No Compliance assets found.") |
|
Hello @merit-maita, thank you for your feedback, i just handled the last comments that you've made everything is good now ! i will talk to @tarraschk so we can get back to you and setup the demo, have a nice afternoon ! |
that would be great, thanks! |
merit-maita
merged commit a44f668
into
demisto:contrib/Galeax_master-1
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
Status
Related Issues
N/A
Description
Allows Cortex to fetch new data (metadata + compliance scans) from Cyberwatch.
Allows Cortex to send metadata to Cyberwatch.
Must have