Skip to content

[Armis Event Collector] Update pagination handling in fetch-events #40682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 11, 2025

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Jul 22, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-53010

Description

Gracefully handle docker timeout due to extended pagination time.

  • Leverage the existing pagination pause-resume mechanism to implement a time cap on pagination.
  • Debug/Info logs alignment: remove debug-log and info-log message prefixes.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jul 22, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Armis/Integrations/ArmisEventCollector
   ArmisEventCollector.py2454382%78–80, 85, 150, 192–198, 208–212, 214, 232–233, 235–236, 238, 275, 277, 493–494, 538, 566–569, 571–575, 577–578, 580–581, 626, 631
TOTAL2454382% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 2.605s ⏱️

@samuelFain samuelFain changed the title [Armis Event Collector] Upgrade pagination in fetch-events [Armis Event Collector] Update pagination handling in fetch-events Jul 22, 2025
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add the release notes and unitesting here.

@samuelFain samuelFain requested a review from JasBeilin August 10, 2025 12:46
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@samuelFain samuelFain added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 10, 2025
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samuelFain samuelFain merged commit 88dd325 into master Aug 11, 2025
22 checks passed
@samuelFain samuelFain deleted the sf-upgrade-armis-event-collector-fetch-events branch August 11, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants