-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Armis Event Collector] Update pagination handling in fetch-events #40682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Armis Event Collector] Update pagination handling in fetch-events #40682
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add the release notes and unitesting here.
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.py
Outdated
Show resolved
Hide resolved
… simplified response handling
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: XSUP-53010
Description
Gracefully handle docker timeout due to extended pagination time.
debug-log
andinfo-log
message prefixes.Must have