Skip to content

Add triggers to hide the port field #40522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 11, 2025
Merged

Conversation

adi88d
Copy link
Contributor

@adi88d adi88d commented Jul 6, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Add triggers logic to hide the "Port" field when a specific engine wasn't used for the following integrations:

  • EDL
  • ExportIndicators
  • PingCastle
  • Publish List
  • Simple API Proxy
  • Syslog v2
  • TAXII Server
  • TAXII2 Server
  • Web File Repository
  • Workday_IAM_Event_Generator
  • XSOAR-Web-Server
  • Microsoft Teams
  • AWS-SNS-Listener

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jul 6, 2025

Your contributed PublishList pack has been modified on files:

Packs/PublishList/Integrations/PublishList/PublishList.yml
Please review the changes here

Copy link

github-actions bot commented Jul 6, 2025

Your contributed SimpleAPIProxy pack has been modified on files:

Packs/SimpleAPIProxy/Integrations/SimpleAPIProxy/SimpleAPIProxy.yml
Please review the changes here

Copy link

github-actions bot commented Jul 6, 2025

Your contributed WebFileRepository pack has been modified on files:

Packs/WebFileRepository/Integrations/WebFileRepository/WebFileRepository.yml
Please review the changes here

Copy link

github-actions bot commented Jul 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener
   AWSSNSListener.py992475%69–70, 74–75, 82, 92–93, 99–109, 116, 142–145, 153
Packs/EDL/Integrations/EDL
   EDL.py81017478%102, 105, 266, 278–280, 282, 311, 335, 376, 400–401, 403–404, 406–407, 471, 524–525, 566–571, 713, 812, 979, 982, 998–1000, 1029–1031, 1034, 1044–1046, 1093–1103, 1112, 1122, 1159–1171, 1173–1175, 1177–1178, 1180–1182, 1184–1185, 1187–1188, 1191–1192, 1195–1196, 1198–1199, 1201, 1209, 1211–1212, 1214, 1216, 1227–1233, 1235, 1237, 1239–1245, 1264, 1266, 1284, 1336, 1359, 1362, 1365, 1371, 1385, 1388, 1391, 1394, 1398, 1402, 1451–1459, 1461–1469, 1477–1496, 1498–1499, 1504, 1506, 1526–1529, 1531–1532, 1534–1535, 1537–1538, 1540, 1564, 1568
Packs/MicrosoftTeams/Integrations/MicrosoftTeams
   MicrosoftTeams.py167638676%301, 307, 371, 373, 413–414, 437, 446, 448, 476–477, 479–482, 484–487, 491, 509, 513, 521–522, 739–740, 773, 796, 889–892, 894–895, 910–911, 920–921, 959, 970, 977–979, 982, 991–992, 1013–1014, 1049–1051, 1053–1054, 1063, 1076–1079, 1082–1084, 1087–1089, 1093, 1102–1103, 1107–1108, 1133, 1151–1158, 1160–1164, 1166–1168, 1170–1172, 1175–1178, 1180, 1182–1199, 1201, 1203–1204, 1207–1210, 1212, 1214–1215, 1217–1220, 1222–1223, 1225, 1230, 1232–1236, 1238–1240, 1342–1345, 1353–1356, 1358–1360, 1362–1365, 1367, 1369, 1420, 1422, 1534–1535, 1547, 1619, 1692, 1694, 1697–1699, 1701–1709, 1711–1712, 1714, 1717, 1736, 1741, 1743, 2038–2039, 2123–2128, 2147–2159, 2260, 2281–2282, 2348, 2357, 2387–2390, 2413–2415, 2428, 2448, 2451, 2454, 2462, 2465–2467, 2473, 2497–2498, 2501, 2550–2552, 2554, 2589–2596, 2598–2604, 2609–2610, 2612–2621, 2625–2628, 2630, 2656–2657, 2670–2672, 2702, 2708–2710, 2717, 2728–2729, 2732, 2736, 2774–2776, 2823–2824, 2827, 2898, 2902, 2914, 2931–2933, 2953, 3000–3001, 3015, 3021–3023, 3043–3045, 3055, 3057–3064, 3066–3068, 3072–3075, 3101, 3106, 3161–3163, 3165–3166, 3168, 3170–3171, 3173–3174, 3176–3178, 3180, 3182–3186, 3188–3191, 3193–3195, 3197, 3199, 3201–3211, 3213–3219, 3298, 3315, 3360–3363, 3366–3367, 3372, 3382–3383, 3394–3395, 3397, 3406, 3432, 3506, 3531, 3535, 3546, 3549, 3566–3567
Packs/PingCastle/Integrations/PingCastle
   PingCastle.py13610324%20–22, 28–29, 35–41, 43–44, 47–48, 50–54, 62–65, 67–70, 72–75, 77–79, 87, 92, 100–102, 110–113, 115–119, 128–130, 132–139, 141–145, 153–156, 189–191, 193–196, 198–201, 203, 205, 209, 211–213, 215–216, 222–224, 226–229, 231–232, 234–235, 238–240
Packs/Syslog/Integrations/Syslogv2
   Syslogv2.py1644274%130, 137, 141–144, 239, 258–270, 272, 274, 349–356, 360–362, 366–371, 373, 376–377
Packs/TAXIIServer/Integrations/TAXII2Server
   TAXII2Server.py4735388%106, 135, 142, 163, 188, 197, 203, 266, 303, 391–392, 489–490, 663–664, 666–669, 671, 684–685, 699–700, 716, 738–741, 761–764, 804–807, 828–831, 865–868, 912–915, 935–938
Packs/TAXIIServer/Integrations/TAXIIServer
   TAXIIServer.py42221848%75, 116, 134–136, 138–139, 141–144, 152, 154, 170–171, 173–174, 176, 178–180, 183–184, 186, 197–198, 200–203, 205, 229–230, 232–233, 235, 242, 253–254, 259, 262, 264–267, 269–272, 276, 278, 298, 337, 342–343, 345, 348–350, 522–523, 525–527, 529–530, 534, 563–564, 569–570, 572, 589, 598–599, 614, 616–627, 629–630, 632, 649–652, 654–655, 657–659, 661, 670–675, 677, 684, 686–689, 691, 709, 760, 765, 767, 781–787, 789, 800–806, 808, 819–823, 825–829, 831, 838–839, 847–849, 851–856, 858–865, 867, 869–874, 876–884, 886–889, 896–897, 899–906, 908–914, 917–919, 922–924, 926–927, 930–933, 935–939
Packs/WebFileRepository/Integrations/WebFileRepository
   WebFileRepository.py91915683%3006, 3015, 3019, 3040, 3061, 3069, 3072–3073, 3075–3078, 3081, 3125, 3142, 3157–3158, 3178, 3195–3198, 3200, 3228–3229, 3231–3237, 3239–3241, 3243, 3250–3252, 3261, 3265, 3268, 3280, 3305, 3314–3316, 3320, 3324, 3330–3332, 3342, 3347, 3360, 3370, 3383–3384, 3387–3390, 3392–3394, 3401, 3439, 3487, 3495, 3571, 3579, 3588–3591, 3593, 3622, 3640–3642, 3650–3652, 3669–3671, 3687–3689, 3724, 3754, 3772, 3792–3796, 3820, 3865, 3877, 3880, 3949, 3962, 3966, 4036, 4040, 4087, 4110–4111, 4113–4115, 4117–4118, 4120–4124, 4126–4127, 4142, 4147, 4152, 4155–4156, 4160, 4163, 4173–4174, 4190–4191, 4198–4199, 4254, 4267, 4288–4289, 4300, 4328, 4355, 4376, 4413, 4424, 4442, 4454–4455, 4498, 4500–4501, 4515–4517, 4519–4521
TOTAL4699115675% 

Tests Skipped Failures Errors Time
418 0 💤 0 ❌ 0 🔥 35.165s ⏱️

adi88d and others added 16 commits July 7, 2025 23:41
update dockers
# Conflicts:
#	Packs/MicrosoftTeams/ReleaseNotes/1_5_35.md
#	Packs/Workday/ReleaseNotes/1_5_2.md
# Conflicts:
#	Packs/MicrosoftTeams/ReleaseNotes/1_5_36.md
#	Packs/Workday/ReleaseNotes/1_5_3.md
# Conflicts:
#	Packs/EDL/ReleaseNotes/3_3_17.md
#	Packs/MicrosoftTeams/ReleaseNotes/1_5_37.md
@adi88d adi88d marked this pull request as ready for review July 22, 2025 14:51
@adi88d adi88d requested a review from Ni-Knight as a code owner July 22, 2025 14:51
@adi88d adi88d requested a review from DeanArbel July 22, 2025 14:51
@adi88d adi88d added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Jul 22, 2025
@adi88d adi88d changed the title add triggers to hide the port field Add triggers to hide the port field Jul 22, 2025
@adi88d adi88d requested a review from RosenbergYehuda July 22, 2025 14:53
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@adi88d adi88d added the ForceMerge Forcing the merge of the PR despite the build status label Aug 11, 2025
@adi88d
Copy link
Contributor Author

adi88d commented Aug 11, 2025

Will need force merge due to the following failing TPB:
TAXII_Feed_Test
https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/jobs/27815613

@DeanArbel DeanArbel merged commit 6b38006 into master Aug 11, 2025
22 of 25 checks passed
@DeanArbel DeanArbel deleted the CIAC-13551-hide-port-param branch August 11, 2025 10:59
scohenkadosh pushed a commit that referenced this pull request Aug 11, 2025
* add triggers to hide the port field

* bump RN
update dockers

* add connect section

* fix conflicts

* add sectionOrder key

* add Collect section

* merge from master

* ignore mypy

* ignore mypy

* merge from master

* update RN

* update RN

* merge from master

* bump RN

* update docker images

* update docker images

* fix mypy error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants