Skip to content

Fixing adding special characters in audit comments of security policies #39608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 22, 2025
Merged

Fixing adding special characters in audit comments of security policies #39608

merged 9 commits into from
Apr 22, 2025

Conversation

mdrobniu
Copy link
Contributor

@mdrobniu mdrobniu commented Apr 18, 2025 •
edited
Loading

& <> + chars are breaking the command
See slack:
https://panw-global.slack.com/archives/C011E5T5K17/p1744962593038919

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@mdrobniu mdrobniu requested a review from jlevypaloalto as a code owner April 18, 2025 13:28
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Apr 18, 2025
@content-bot content-bot changed the base branch from master to contrib/mdrobniu_patch-2 April 18, 2025 13:30
@content-bot content-bot requested a review from mmhw April 18, 2025 13:30
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @mdrobniu, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

mmhw
mmhw requested changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mdrobniu ,
Thank you for your contribution!
Good work :)

Please bump the pack version in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes -i Packs/PAN-OS command - for more information please see: https://xsoar.pan.dev/docs/documentation/release-notes.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

@mdrobniu
Update pack_metadata.json
d87b988 
Bumping up the pack version
@mdrobniu
Copy link
Contributor Author

@mmhw Done.

@mmhw
Copy link
Contributor

mmhw commented Apr 22, 2025

Hi @mdrobniu,
Note that you also need to add a Release Notes file.

Additionally, please note that you also need to fill out the contribution form.

Thanks!

mdrobniu added 2 commits April 22, 2025 12:27
@mdrobniu
Create 2_3_10.md
d5f0915 
adding release notes
@mdrobniu
Update 2_3_10.md
6101424 
fixing md
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Apr 22, 2025
@mdrobniu
Copy link
Contributor Author

@mmhw Done

@mdrobniu
Copy link
Contributor Author

@mmhw The pack version moved to .11 in the meanwhile.

mmhw
mmhw approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@mmhw mmhw merged commit f69acda into demisto:contrib/mdrobniu_patch-2 Apr 22, 2025
13 of 14 checks passed
@mdrobniu mdrobniu deleted the patch-2 branch April 22, 2025 13:05
@content-bot content-bot mentioned this pull request Apr 22, 2025
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

DeanArbel pushed a commit that referenced this pull request Apr 23, 2025
@content-bot @mdrobniu
Fixing adding special characters in audit comments of security polici…
e9a5e39 
…es (#39608) (#39662)

* Fixing adding special characters in audit comments of security policies

& <> + chars are breaking the command
See slack:
https://panw-global.slack.com/archives/C011E5T5K17/p1744962593038919

* Update CONTRIBUTORS.json

* Update pack_metadata.json

Bumping up the pack version

* Create 2_3_10.md

adding release notes

* Update 2_3_10.md

fixing md

* Create 2_3_11.md

bumping up version again

* Update pack_metadata.json

* Delete Packs/PAN-OS/ReleaseNotes/2_3_10.md

Co-authored-by: Maciej Drobniuch <mdrobniuch@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmhw mmhw mmhw approved these changes

@jlevypaloalto jlevypaloalto Awaiting requested review from jlevypaloalto

Assignees

@mmhw mmhw

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdrobniu @content-bot @mmhw