Skip to content

Add rawJSON to fetched indicator object in Feed MISP Threat Actors #39599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iamtimroberts
Copy link
Contributor

Added rawJSON to fetched indicator object in Feed MISP Threat Actors to enable custom mapping.

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: N/A

Description

Currently unable to build a custom mapper for this Feed Integration due to the rawJSON not being returned. This causes no data to be returned in the Classifier/Mapper editors when you pull from this instance. The simple addition of 'rawJSON': threat_actor to the returned indicators object from fetch_indicators_command allows the Classifier/Mapper editors to actually fetch data to build the mapper off of.

Must have

  • [x ] Tests
  • [ x] Documentation

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Apr 17, 2025
@content-bot content-bot changed the base branch from master to contrib/iamtimroberts_misp-threat-actor-return-rawjson April 17, 2025 13:29
@content-bot content-bot requested review from MLainer1 and mmhw April 17, 2025 13:29
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @iamtimroberts, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my standpoint

Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamtimroberts,
Thank you for your contribution!
Good work :)

@mmhw
Copy link
Contributor

mmhw commented Apr 21, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@iamtimroberts, Please be sure to sign here.

@iamtimroberts
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@iamtimroberts, Please be sure to sign here.

I've already filled that out - when I click the link it shows I've already signed it.

@mmhw
Copy link
Contributor

mmhw commented Apr 22, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@iamtimroberts, Please be sure to sign here.

I've already filled that out - when I click the link it shows I've already signed it.

Hi @iamtimroberts,
Did you sign here? https://cla-assistant.io/demisto/content?pullRequest=39599

@iamtimroberts
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@iamtimroberts, Please be sure to sign here.

I've already filled that out - when I click the link it shows I've already signed it.

Hi @iamtimroberts, Did you sign here? https://cla-assistant.io/demisto/content?pullRequest=39599

Yup - its showing signed:

image

@mmhw
Copy link
Contributor

mmhw commented Apr 23, 2025

Hi @iamtimroberts, Please note that I sent you an email.

@iamtimroberts
Copy link
Contributor Author

I didn't realize that the commit was from my corporate palo alto account so that was the discrepancy with the CLA. It is now signed.

@mmhw mmhw merged commit 14c8348 into demisto:contrib/iamtimroberts_misp-threat-actor-return-rawjson Apr 24, 2025
39 of 40 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

DeanArbel pushed a commit that referenced this pull request Apr 24, 2025
…to enable custom mapping. (#39599) (#39697)

Co-authored-by: Tim Roberts <timroberts213@gmail.com>
Co-authored-by: troberts <troberts@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants